Move more extensions code from ChromeContentBrowserClient to ChromeContentBrowserClientExtensionsPa…

Move more extensions code from ChromeContentBrowserClient to ChromeContentBrowserClientExtensionsPart.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287185

[Lei Zhang, 2014-08-01 22:46:36]

Almost everything is just a straight-forward move, maybe with a bit of
reformatting.

https://codereview.chromium.org/434023004/diff/1/chrome/browser/extensions/ch...
File chrome/browser/extensions/chrome_content_browser_client_extensions_part.h
(right):

https://codereview.chromium.org/434023004/diff/1/chrome/browser/extensions/ch...
chrome/browser/extensions/chrome_content_browser_client_extensions_part.h:51:
static bool ShouldAllowOpenURL(content::SiteInstance* site_instance,
I'm too lazy to write:

for (size_t i = 0; i < extra_parts_.size(); ++i) {
  bool result;
  if (PartFunction(..., &result)
     return result;
}

for all of the methods above, especially since many of them are one offs just
for extensions code. If I do more cleanup in the future and find that we can use
the pattern above, I'll convert these static methods to virtual methods in
ChromeContentBrowserClientParts.

[Yoyo Zhou, 2014-08-01 23:11:35]

LGTM

https://codereview.chromium.org/434023004/diff/1/chrome/browser/chrome_conten...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/434023004/diff/1/chrome/browser/chrome_conten...
chrome/browser/chrome_content_browser_client.cc:217: #include
"chrome/browser/extensions/extension_service.h"
That these are still included is surprising.

https://codereview.chromium.org/434023004/diff/1/chrome/browser/extensions/ch...
File chrome/browser/extensions/chrome_content_browser_client_extensions_part.h
(right):

https://codereview.chromium.org/434023004/diff/1/chrome/browser/extensions/ch...
chrome/browser/extensions/chrome_content_browser_client_extensions_part.h:51:
static bool ShouldAllowOpenURL(content::SiteInstance* site_instance,
On 2014/08/01 22:46:36, Lei Zhang wrote:
> I'm too lazy to write:
> 
> for (size_t i = 0; i < extra_parts_.size(); ++i) {
>   bool result;
>   if (PartFunction(..., &result)
>      return result;
> }
> 
> for all of the methods above, especially since many of them are one offs just
> for extensions code. If I do more cleanup in the future and find that we can
use
> the pattern above, I'll convert these static methods to virtual methods in
> ChromeContentBrowserClientParts.

I imagine that many of these methods exist on ChromeContentBrowserClient solely
because of extensions (i.e. the only difference from the content module is what
extensions does, not what chrome does). Seems okay to me for now. Up to you
whether this merits a TODO.

[Lei Zhang, 2014-08-01 23:16:43]

https://codereview.chromium.org/434023004/diff/1/chrome/browser/chrome_conten...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/434023004/diff/1/chrome/browser/chrome_conten...
chrome/browser/chrome_content_browser_client.cc:217: #include
"chrome/browser/extensions/extension_service.h"
On 2014/08/01 23:11:35, Yoyo Zhou wrote:
> That these are still included is surprising.

I didn't move *everything* in this CL.

[Lei Zhang, 2014-08-01 23:16:46]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-08-01 23:19:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/434023004/1

[Lei Zhang, 2014-08-02 01:45:11]

The CQ bit was unchecked by thestig@chromium.org

[Lei Zhang, 2014-08-02 01:46:36]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-08-02 01:48:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/434023004/20001

[commit-bot: I haz the power, 2014-08-02 07:58:18]

Change committed as 287185