Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 433983002: LayoutTests for writing empty Blob/File/FileList to IndexedDB. (Closed)

Created:
6 years, 4 months ago by pwnall-personal
Modified:
5 years, 9 months ago
Reviewers:
michaeln, jsbell, cmumford
CC:
cmumford, alecflett, blink-reviews, dgrogan, jsbell+idb_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

LayoutTests for writing empty Blob/File/FileList to IndexedDB. At the time these tests were written, they triggered DCHECKs in webkit/common/blob/blob_data.cc and webkit/browser/blob/blob_storage_context.cc This must only be landed after the DCHECKs are removed. CL: https://codereview.chromium.org/431143002 BUG=399323 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191957

Patch Set 1 : Done with files. #

Patch Set 2 : Added Filesystem test. #

Total comments: 30

Patch Set 3 : Addressed feedback. #

Total comments: 1

Patch Set 4 : Updated test expectations to match ToT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -19 lines) Patch
M LayoutTests/storage/indexeddb/blob-basics-metadata.html View 1 2 3 7 chunks +12 lines, -20 lines 0 comments Download
M LayoutTests/storage/indexeddb/blob-basics-metadata-expected.txt View 1 2 3 4 chunks +4 lines, -0 lines 0 comments Download
A LayoutTests/storage/indexeddb/empty-blob-file.html View 1 2 1 chunk +124 lines, -0 lines 0 comments Download
A LayoutTests/storage/indexeddb/empty-blob-file-expected.txt View 1 2 1 chunk +122 lines, -0 lines 0 comments Download
A LayoutTests/storage/indexeddb/empty-filesystem-file.html View 1 2 1 chunk +90 lines, -0 lines 0 comments Download
A LayoutTests/storage/indexeddb/empty-filesystem-file-expected.txt View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A + LayoutTests/storage/indexeddb/resources/empty.txt View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
pwnall-personal
PTAL?
6 years, 4 months ago (2014-07-31 18:22:21 UTC) #1
jsbell
Logic of the tests looks good, some nitpicks on the formatting, naming, tags, etc. https://codereview.chromium.org/433983002/diff/60001/LayoutTests/storage/indexeddb/empty-blob-file.html ...
6 years, 4 months ago (2014-07-31 18:53:51 UTC) #2
pwnall-personal
Thank you for the quick and thorough feedback! Where applicable, I also updated the file ...
6 years, 4 months ago (2014-08-01 00:01:12 UTC) #3
jsbell
lgtm (but as noted, this will need to wait until the root-cause of the bug ...
6 years, 4 months ago (2014-08-01 00:12:47 UTC) #4
cmumford
LGTM + 1 comment. Now that crrev.com/942633004 has landed to fix issue 399323 these tests ...
5 years, 9 months ago (2015-03-14 14:18:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/433983002/100001
5 years, 9 months ago (2015-03-16 21:19:57 UTC) #9
pwnall-personal
Thanks so much for fixing the underlying bug! On 2015/03/14 14:18:50, cmumford wrote: > LGTM ...
5 years, 9 months ago (2015-03-16 21:20:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/433983002/100001
5 years, 9 months ago (2015-03-17 00:23:05 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 00:23:53 UTC) #14
Message was sent while issue was closed. 
Committed patchset #4 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191957

Powered by Google App Engine
This is Rietveld 408576698