Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: pkg/analysis_server/lib/src/computer/computer_navigation.dart

Issue 433973003: Ignore 'dynamic' in the navigation computer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/analysis_notification_navigation_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/computer/computer_navigation.dart
diff --git a/pkg/analysis_server/lib/src/computer/computer_navigation.dart b/pkg/analysis_server/lib/src/computer/computer_navigation.dart
index 98c228054fd5e2ec3214fc8f74e664e957203b9f..03ea941d36d4e762d18b0ed7095b8e2a143ace08 100644
--- a/pkg/analysis_server/lib/src/computer/computer_navigation.dart
+++ b/pkg/analysis_server/lib/src/computer/computer_navigation.dart
@@ -31,7 +31,7 @@ class DartUnitNavigationComputer {
}
void _addRegion(int offset, int length, Element element) {
- if (element == null) {
+ if (element == null || element == DynamicElementImpl.instance) {
return;
}
if (element is FieldFormalParameterElement) {
@@ -104,7 +104,9 @@ class _DartUnitNavigationComputerVisitor extends RecursiveAstVisitor {
lastNode = firstNode;
}
if (firstNode != null && lastNode != null) {
- computer._addRegion_nodeStart_nodeEnd(firstNode, lastNode,
+ computer._addRegion_nodeStart_nodeEnd(
+ firstNode,
+ lastNode,
node.element);
}
}
@@ -149,14 +151,18 @@ class _DartUnitNavigationComputerVisitor extends RecursiveAstVisitor {
@override
visitPartDirective(PartDirective node) {
- computer._addRegion_tokenStart_nodeEnd(node.keyword, node.uri,
+ computer._addRegion_tokenStart_nodeEnd(
+ node.keyword,
+ node.uri,
node.element);
return super.visitPartDirective(node);
}
@override
visitPartOfDirective(PartOfDirective node) {
- computer._addRegion_tokenStart_nodeEnd(node.keyword, node.libraryName,
+ computer._addRegion_tokenStart_nodeEnd(
+ node.keyword,
+ node.libraryName,
node.element);
return super.visitPartOfDirective(node);
}
« no previous file with comments | « no previous file | pkg/analysis_server/test/analysis_notification_navigation_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698