Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 433943004: Revert "Add a dependency on the AOT shi..." and remove adhoc pexe->nexe disables. (Closed)

Created:
6 years, 4 months ago by jvoung (off chromium)
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Revert "Add a dependency on the AOT shi..." and remove adhoc pexe->nexe disables. This reverts commit r284737. It's no longer needed since build_pnacl_newlib plus enable_${arch} no longer imply that the pexe should be translated. That's controlled by the translate_pexe_with_build flag instead. Also remove the adhoc uses of enable_x86_32: 0, etc. now that pexe -> nexe is off by default. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289144

Patch Set 1 #

Patch Set 2 : remove other pexe -> nexe disablement #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -53 lines) Patch
M chrome/test/data/nacl/nacl_test_data.gyp View 1 20 chunks +0 lines, -51 lines 0 comments Download
M remoting/remoting_nacl.gyp View 1 1 chunk +0 lines, -2 lines 2 comments Download

Messages

Total messages: 10 (0 generated)
jvoung (off chromium)
https://codereview.chromium.org/433943004/diff/20001/remoting/remoting_nacl.gyp File remoting/remoting_nacl.gyp (left): https://codereview.chromium.org/433943004/diff/20001/remoting/remoting_nacl.gyp#oldcode150 remoting/remoting_nacl.gyp:150: 'enable_x86_64': 0, Is this because the nexe is not ...
6 years, 4 months ago (2014-07-31 17:05:25 UTC) #1
Mark Seaborn
LGTM. You might want to test this using a clobber build before committing.
6 years, 4 months ago (2014-07-31 18:04:38 UTC) #2
jvoung (off chromium)
Thanks, did a local clobber and also "git cl try --clobber"
6 years, 4 months ago (2014-07-31 21:17:39 UTC) #3
jvoung (off chromium)
or +wez for remoting/remoting_nacl.gyp OWNERs
6 years, 4 months ago (2014-08-12 17:34:32 UTC) #4
Wez
I think it's best that Sergey looks at this; he was out yesterday but is ...
6 years, 4 months ago (2014-08-12 17:57:42 UTC) #5
Sergey Ulanov
lgtm https://codereview.chromium.org/433943004/diff/20001/remoting/remoting_nacl.gyp File remoting/remoting_nacl.gyp (left): https://codereview.chromium.org/433943004/diff/20001/remoting/remoting_nacl.gyp#oldcode150 remoting/remoting_nacl.gyp:150: 'enable_x86_64': 0, On 2014/07/31 17:05:25, jvoung wrote: > ...
6 years, 4 months ago (2014-08-12 18:34:06 UTC) #6
jvoung (off chromium)
Thanks!
6 years, 4 months ago (2014-08-12 19:50:29 UTC) #7
jvoung (off chromium)
The CQ bit was checked by jvoung@chromium.org
6 years, 4 months ago (2014-08-12 19:50:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/433943004/20001
6 years, 4 months ago (2014-08-12 19:54:56 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 01:20:16 UTC) #10
Message was sent while issue was closed.
Change committed as 289144

Powered by Google App Engine
This is Rietveld 408576698