Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: pkg/polymer/test/build/import_inliner_test.dart

Issue 433913002: Strip bindings before calling Uri.parse (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer/lib/src/build/import_inliner.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer/test/build/import_inliner_test.dart
diff --git a/pkg/polymer/test/build/import_inliner_test.dart b/pkg/polymer/test/build/import_inliner_test.dart
index f6daa409ff7a720a50bf6723a0b76aa3e33bcd95..382eaf3ef85c05a3bc10cee5f6df1e61aee0db07 100644
--- a/pkg/polymer/test/build/import_inliner_test.dart
+++ b/pkg/polymer/test/build/import_inliner_test.dart
@@ -173,11 +173,11 @@ void importTests() {
'<!DOCTYPE html><html><head>'
'<script type="application/dart">/*3*/</script>'
'</head></html>',
- 'a|web/*test_%foo_04!.html':
jakemac 2014/07/31 15:06:37 Barback started complaining about paths that don't
Siggi Cherem (dart-lang) 2014/07/31 21:54:22 Weird, I'm surprised it didn't fail in the bots to
jakemac 2014/08/01 15:20:47 Oddly enough this just stopped happening. I have r
+ 'a|web/test_fo*o_04!.html':
'<!DOCTYPE html><html><head>'
'<script type="application/dart">/*4*/</script>'
'</head></html>',
- 'a|web/%05_test.html':
+ 'a|web/foo_05_test.html':
'<!DOCTYPE html><html><head>'
'<script type="application/dart">/*5*/</script>'
'</head></html>',
@@ -188,10 +188,10 @@ void importTests() {
'library a.web.foo_02_test_html_0;\n/*2*/', // Allows numbers in the middle.
'a|web/test_03.html.0.dart':
'library a.web.test_03_html_0;\n/*3*/', // Allows numbers at the end.
- 'a|web/*test_%foo_04!.html.0.dart':
- 'library a.web._test__foo_04__html_0;\n/*4*/', // Replaces invalid characters with _.
- 'a|web/%05_test.html.0.dart':
- 'library a.web._05_test_html_0;\n/*5*/', // Replace invalid character followed by number.
+ 'a|web/test_fo*o_04!.html.0.dart':
+ 'library a.web.test_fo_o_04__html_0;\n/*4*/', // Replaces invalid characters with _.
+ 'a|web/foo_05_test.html.0.dart':
+ 'library a.web.foo_05_test_html_0;\n/*5*/', // Replace invalid character followed by number.
});
testPhases('no transformation outside web/', phases,
@@ -883,6 +883,30 @@ void urlAttributeTests() {
'<img src="foo/{{bar}}">'
'</body></html>',
});
+
+ testPhases('arbitrary bindings can exist in paths', phases, {
+ 'a|web/test.html':
+ '<!DOCTYPE html><html><head></head><body>'
+ '<img src="./{{(bar[2] + baz[\'foo\']) * 14 / foobar() - 0.5}}.jpg">'
+ '</body></html>',
+ }, {
+ 'a|web/test.html':
+ '<!DOCTYPE html><html><head></head><body>'
+ '<img src="{{(bar[2] + baz[\'foo\']) * 14 / foobar() - 0.5}}.jpg">'
+ '</body></html>',
+ });
+
+ testPhases('multiple bindings can exist in paths', phases, {
+ 'a|web/test.html':
+ '<!DOCTYPE html><html><head></head><body>'
+ '<img src="./{{bar[0]}}/{{baz[1]}}.{{extension}}">'
+ '</body></html>',
+ }, {
+ 'a|web/test.html':
+ '<!DOCTYPE html><html><head></head><body>'
+ '<img src="{{bar[0]}}/{{baz[1]}}.{{extension}}">'
+ '</body></html>',
+ });
}
void entryPointTests() {
« no previous file with comments | « pkg/polymer/lib/src/build/import_inliner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698