athena/activity/activity_manager_unittest.cc - Issue 433863002: Disable athena_unittests failing memory bot.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: athena/activity/activity_manager_unittest.cc

Issue 433863002: Disable athena_unittests failing memory bot. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 /// Copyright 2014 The Chromium Authors. All rights reserved.	1 /// Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "athena/activity/public/activity_manager.h"	5 #include "athena/activity/public/activity_manager.h"

6	6

7 #include "athena/activity/public/activity_factory.h"	7 #include "athena/activity/public/activity_factory.h"

8 #include "athena/test/athena_test_base.h"	8 #include "athena/test/athena_test_base.h"

9	9

10 typedef athena::test::AthenaTestBase ActivityManagerTest;	10 typedef athena::test::AthenaTestBase ActivityManagerTest;

11	11

12 TEST_F(ActivityManagerTest, Basic) {	12 // TODO(flackr): Fix memory leak and re-enable - http://crbug.com/399241

	13 TEST_F(ActivityManagerTest, DISABLED_Basic) {

13 athena::ActivityManager::Get()->AddActivity(	14 athena::ActivityManager::Get()->AddActivity(
	tfarina 2014/07/31 17:27:10 If my analysis is right this is because ActivityVi If my analysis is right this is because ActivityViewManager is leaking the activity created: https://chromium.googlesource.com/chromium/src/+/master/athena/activity/activ... Although, ActivityManagerImpl deletes it in its dtor. https://chromium.googlesource.com/chromium/src/+/master/athena/activity/activ... Then, what could be is that ActivityManager is not getting destroyed in the unittest?
14 athena::ActivityFactory::Get()->CreateWebActivity(NULL, GURL()));	15 athena::ActivityFactory::Get()->CreateWebActivity(NULL, GURL()));

15 }	16 }

OLD	NEW

« no previous file with comments | « no previous file | athena/home/home_card_unittest.cc » ('j') | no next file with comments »