Issue 433863002: Disable athena_unittests failing memory bot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 433863002: Disable athena_unittests failing memory bot. (Closed)

Created:
6 years, 4 months ago by flackr

Modified:
6 years, 4 months ago

Reviewers:
tfarina, James Cook, pneubeck (no reviews)

CC:
chromium-reviews, oshima

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable athena_unittests failing memory bot. R=pneubeck@chromium.org TBR=jamescook BUG=399241 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286769

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	athena/activity/activity_manager_unittest.cc	View		1 chunk	+2 lines, -1 line	1 comment	Download
	M	athena/home/home_card_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

flackr

Committed patchset #1 manually as r286769 (presubmit successful).

6 years, 4 months ago (2014-07-31 12:44:05 UTC) #3

tfarina

6 years, 4 months ago (2014-07-31 17:27:10 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/433863002/diff/1/athena/activity/activity_man...
File athena/activity/activity_manager_unittest.cc (right):

https://codereview.chromium.org/433863002/diff/1/athena/activity/activity_man...
athena/activity/activity_manager_unittest.cc:14:
athena::ActivityManager::Get()->AddActivity(
If my analysis is right this is because ActivityViewManager is leaking the
activity created:
https://chromium.googlesource.com/chromium/src/+/master/athena/activity/activ...

Although, ActivityManagerImpl deletes it in its dtor.
https://chromium.googlesource.com/chromium/src/+/master/athena/activity/activ...

Then, what could be is that ActivityManager is not getting destroyed in the
unittest?

Expand Messages | Collapse Messages