Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 43383006: Clean up the GrTHashTable API. (Closed)

Created:
7 years, 1 month ago by mtklein
Modified:
7 years, 1 month ago
Reviewers:
jvanverth1, bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Clean up the GrTHashTable API. removeAt() and slowFindIndex() were only used by GrFontCache, and didn't really need to exist: they can be replaced by a simple remove() call. This new code should actually be faster; slowFindIndex() was O(N), and this should be O(lg N). BUG= Committed: http://code.google.com/p/skia/source/detail?r=11973

Patch Set 1 #

Patch Set 2 : add comment back #

Total comments: 2

Patch Set 3 : remove ctor #

Patch Set 4 : boo, default template arguments on a function are C++11... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -77 lines) Patch
M src/gpu/GrTHashTable.h View 1 2 3 6 chunks +18 lines, -56 lines 0 comments Download
M src/gpu/GrTextStrike.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrTextStrike.cpp View 3 chunks +9 lines, -10 lines 0 comments Download
M src/gpu/GrTextStrike_impl.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M tests/HashCacheTest.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
7 years, 1 month ago (2013-10-25 20:44:07 UTC) #1
bsalomon
lgtm w/ one q https://codereview.chromium.org/43383006/diff/30001/src/gpu/GrTextStrike_impl.h File src/gpu/GrTextStrike_impl.h (right): https://codereview.chromium.org/43383006/diff/30001/src/gpu/GrTextStrike_impl.h#newcode19 src/gpu/GrTextStrike_impl.h:19: explicit Key(const GrKey* fontScalarKey) { ...
7 years, 1 month ago (2013-10-25 20:48:46 UTC) #2
mtklein
https://codereview.chromium.org/43383006/diff/30001/src/gpu/GrTextStrike_impl.h File src/gpu/GrTextStrike_impl.h (right): https://codereview.chromium.org/43383006/diff/30001/src/gpu/GrTextStrike_impl.h#newcode19 src/gpu/GrTextStrike_impl.h:19: explicit Key(const GrKey* fontScalarKey) { On 2013/10/25 20:48:47, bsalomon ...
7 years, 1 month ago (2013-10-25 21:08:21 UTC) #3
bsalomon
lgtm
7 years, 1 month ago (2013-10-25 21:10:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/43383006/80001
7 years, 1 month ago (2013-10-27 19:21:48 UTC) #5
commit-bot: I haz the power
Retried try job too often on Build-Ubuntu12-GCC-x86_64-Release-Trybot for step(s) BuildBench, BuildEverything, BuildTools http://skiabot-master.pogerlabs.com:10117/buildstatus?builder=Build-Ubuntu12-GCC-x86_64-Release-Trybot&number=862
7 years, 1 month ago (2013-10-27 19:28:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/43383006/190001
7 years, 1 month ago (2013-10-27 20:38:48 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-10-27 20:50:26 UTC) #8
Message was sent while issue was closed.
Change committed as 11973

Powered by Google App Engine
This is Rietveld 408576698