Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: tools/presubmit.py

Issue 433813002: Add iteration macros. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: No rvalues with MSVC Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/cctest/test-utils.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2012 the V8 project authors. All rights reserved. 3 # Copyright 2012 the V8 project authors. All rights reserved.
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 Lint files to check that they follow the google code style. 222 Lint files to check that they follow the google code style.
223 """ 223 """
224 224
225 def IsRelevant(self, name): 225 def IsRelevant(self, name):
226 return name.endswith('.cc') or name.endswith('.h') 226 return name.endswith('.cc') or name.endswith('.h')
227 227
228 def IgnoreDir(self, name): 228 def IgnoreDir(self, name):
229 return (super(CppLintProcessor, self).IgnoreDir(name) 229 return (super(CppLintProcessor, self).IgnoreDir(name)
230 or (name == 'third_party')) 230 or (name == 'third_party'))
231 231
232 IGNORE_LINT = ['flag-definitions.h'] 232 IGNORE_LINT = ['flag-definitions.h', 'foreach.h']
233 233
234 def IgnoreFile(self, name): 234 def IgnoreFile(self, name):
235 return (super(CppLintProcessor, self).IgnoreFile(name) 235 return (super(CppLintProcessor, self).IgnoreFile(name)
236 or (name in CppLintProcessor.IGNORE_LINT)) 236 or (name in CppLintProcessor.IGNORE_LINT))
237 237
238 def GetPathsToSearch(self): 238 def GetPathsToSearch(self):
239 return ['src', 'include', 'samples', join('test', 'cctest')] 239 return ['src', 'include', 'samples', join('test', 'cctest')]
240 240
241 def GetCpplintScript(self, prio_path): 241 def GetCpplintScript(self, prio_path):
242 for path in [prio_path] + os.environ["PATH"].split(os.pathsep): 242 for path in [prio_path] + os.environ["PATH"].split(os.pathsep):
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
444 success = SourceProcessor().Run(workspace) and success 444 success = SourceProcessor().Run(workspace) and success
445 success = CheckGeneratedRuntimeTests(workspace) and success 445 success = CheckGeneratedRuntimeTests(workspace) and success
446 if success: 446 if success:
447 return 0 447 return 0
448 else: 448 else:
449 return 1 449 return 1
450 450
451 451
452 if __name__ == '__main__': 452 if __name__ == '__main__':
453 sys.exit(Main()) 453 sys.exit(Main())
OLDNEW
« no previous file with comments | « test/cctest/test-utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698