Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: Source/modules/serviceworkers/Cache.cpp

Issue 433793002: Introducing the WebServiceWorkerCache. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: cleaner and oilpan Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/serviceworkers/Cache.h ('k') | Source/modules/serviceworkers/CacheTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/Cache.cpp
diff --git a/Source/modules/serviceworkers/Cache.cpp b/Source/modules/serviceworkers/Cache.cpp
index 80cdd1f5afa46eb34e00b085d285ac18bc6f434c..f90bad6f5ca0dbe75f7723b405acf1d92f8efa7e 100644
--- a/Source/modules/serviceworkers/Cache.cpp
+++ b/Source/modules/serviceworkers/Cache.cpp
@@ -5,96 +5,303 @@
#include "config.h"
#include "modules/serviceworkers/Cache.h"
+#include "bindings/core/v8/Dictionary.h"
#include "bindings/core/v8/ScriptPromiseResolver.h"
#include "bindings/core/v8/ScriptState.h"
+#include "bindings/core/v8/V8ThrowException.h"
+#include "core/dom/DOMException.h"
+#include "modules/serviceworkers/Request.h"
+#include "modules/serviceworkers/Response.h"
+#include "public/platform/WebServiceWorkerCache.h"
namespace blink {
namespace {
-ScriptPromise rejectAsNotImplemented(ScriptState* scriptState)
+WebServiceWorkerCache::QueryParams queryParamsFromDictionary(const Dictionary& dictionary)
{
- RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
- const ScriptPromise promise = resolver->promise();
- resolver->reject(DOMException::create(NotSupportedError, "Cache is not implemented"));
- return promise;
+ WebServiceWorkerCache::QueryParams queryParams;
+ DictionaryHelper::get(dictionary, "ignoreSearch", queryParams.ignoreSearch);
+ DictionaryHelper::get(dictionary, "ignoreMethod", queryParams.ignoreMethod);
+ DictionaryHelper::get(dictionary, "ignoreVary", queryParams.ignoreVary);
+ DictionaryHelper::get(dictionary, "prefixMatch", queryParams.prefixMatch);
+ {
+ String cacheName;
+ DictionaryHelper::get(dictionary, "cacheName", cacheName);
+ queryParams.cacheName = cacheName;
+ }
+ return queryParams;
}
+// FIXME: Consider using CallbackPromiseAdapter.
+class CacheMatchCallbacks : public WebServiceWorkerCache::CacheMatchCallbacks {
+ WTF_MAKE_NONCOPYABLE(CacheMatchCallbacks);
+public:
+ CacheMatchCallbacks(PassRefPtr<ScriptPromiseResolver> resolver)
+ : m_resolver(resolver) { }
+
+ virtual void onSuccess(WebServiceWorkerResponse* webResponse) OVERRIDE
+ {
+ m_resolver->resolve(Response::create(m_resolver->scriptState()->executionContext(), *webResponse));
+ m_resolver.clear();
+ }
+
+ virtual void onError(WebServiceWorkerCacheError* reason) OVERRIDE
+ {
+ m_resolver->reject(Cache::domExceptionForCacheError(*reason));
+ m_resolver.clear();
+ }
+
+private:
+ RefPtr<ScriptPromiseResolver> m_resolver;
+};
+
+// FIXME: Consider using CallbackPromiseAdapter.
+class CacheWithResponsesCallbacks : public WebServiceWorkerCache::CacheWithResponsesCallbacks {
+ WTF_MAKE_NONCOPYABLE(CacheWithResponsesCallbacks);
+public:
+ CacheWithResponsesCallbacks(PassRefPtr<ScriptPromiseResolver> resolver)
+ : m_resolver(resolver) { }
+
+ virtual void onSuccess(WebVector<WebServiceWorkerResponse>* webResponses) OVERRIDE
+ {
+ HeapVector<Member<Response> > responses;
+ for (size_t i = 0; i < webResponses->size(); ++i)
+ responses.append(Response::create(m_resolver->scriptState()->executionContext(), (*webResponses)[i]));
+ m_resolver->resolve(responses);
+ m_resolver.clear();
+ }
+
+ virtual void onError(WebServiceWorkerCacheError* reason) OVERRIDE
+ {
+ m_resolver->reject(Cache::domExceptionForCacheError(*reason));
+ m_resolver.clear();
+ }
+
+private:
+ RefPtr<ScriptPromiseResolver> m_resolver;
+};
+
+// FIXME: Consider using CallbackPromiseAdapter.
+class CacheWithRequestsCallbacks : public WebServiceWorkerCache::CacheWithRequestsCallbacks {
+ WTF_MAKE_NONCOPYABLE(CacheWithRequestsCallbacks);
+public:
+ CacheWithRequestsCallbacks(PassRefPtr<ScriptPromiseResolver> resolver)
+ : m_resolver(resolver) { }
+
+ virtual void onSuccess(WebVector<WebServiceWorkerRequest>* webRequests) OVERRIDE
+ {
+ HeapVector<Member<Request> > requests;
+ for (size_t i = 0; i < webRequests->size(); ++i)
+ requests.append(Request::create(m_resolver->scriptState()->executionContext(), (*webRequests)[i]));
+ m_resolver->resolve(requests);
+ m_resolver.clear();
+ }
+
+ virtual void onError(WebServiceWorkerCacheError* reason) OVERRIDE
+ {
+ m_resolver->reject(Cache::domExceptionForCacheError(*reason));
+ m_resolver.clear();
+ }
+
+private:
+ RefPtr<ScriptPromiseResolver> m_resolver;
+};
+
+ScriptPromise rejectForCacheError(ScriptState* scriptState, WebServiceWorkerCacheError error)
+{
+ return ScriptPromise::rejectWithDOMException(scriptState, Cache::domExceptionForCacheError(error));
}
+ScriptPromise rejectAsNotImplemented(ScriptState* scriptState)
+{
+ return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(NotSupportedError, "Cache is not implemented"));
+}
+
+} // namespace
+
Cache* Cache::create(WebServiceWorkerCache* webCache)
{
return new Cache(webCache);
}
-// FIXME: Implement these methods.
-ScriptPromise Cache::match(ScriptState* scriptState, Request* request, const Dictionary& queryParams)
+ScriptPromise Cache::match(ScriptState* scriptState, Request* originalRequest, const Dictionary& queryParamsDict)
{
- return rejectAsNotImplemented(scriptState);
+ TrackExceptionState exceptionState;
+ Request* request = Request::create(scriptState->executionContext(), originalRequest, exceptionState);
+ if (exceptionState.hadException()) {
+ // FIXME: We should throw the caught error.
+ return rejectForCacheError(scriptState, WebServiceWorkerCacheErrorNotFound);
+ }
+ return matchImpl(scriptState, request, queryParamsDict);
}
-ScriptPromise Cache::match(ScriptState* scriptState, const String& requestString, const Dictionary& queryParams)
+ScriptPromise Cache::match(ScriptState* scriptState, const String& requestString, const Dictionary& queryParamsDict)
{
- return rejectAsNotImplemented(scriptState);
+ TrackExceptionState exceptionState;
+ Request* request = Request::create(scriptState->executionContext(), requestString, exceptionState);
+ if (exceptionState.hadException()) {
+ // FIXME: We should throw the caught error.
+ return rejectForCacheError(scriptState, WebServiceWorkerCacheErrorNotFound);
+ }
+ return matchImpl(scriptState, request, queryParamsDict);
}
-ScriptPromise Cache::matchAll(ScriptState* scriptState, Request* request, const Dictionary& queryParams)
+ScriptPromise Cache::matchAll(ScriptState* scriptState, Request* originalRequest, const Dictionary& queryParamsDict)
{
- return rejectAsNotImplemented(scriptState);
+ TrackExceptionState exceptionState;
+ Request* request = Request::create(scriptState->executionContext(), originalRequest, exceptionState);
+ if (exceptionState.hadException()) {
+ // FIXME: We should throw the caught error.
+ return rejectForCacheError(scriptState, WebServiceWorkerCacheErrorNotFound);
+ }
+ return matchAllImpl(scriptState, request, queryParamsDict);
}
-ScriptPromise Cache::matchAll(ScriptState* scriptState, const String& requestString, const Dictionary& queryParams)
+ScriptPromise Cache::matchAll(ScriptState* scriptState, const String& requestString, const Dictionary& queryParamsDict)
{
- return rejectAsNotImplemented(scriptState);
+ TrackExceptionState exceptionState;
+ Request* request = Request::create(scriptState->executionContext(), requestString, exceptionState);
+ if (exceptionState.hadException()) {
+ // FIXME: We should throw the caught error.
+ return rejectForCacheError(scriptState, WebServiceWorkerCacheErrorNotFound);
+ }
+ return matchAllImpl(scriptState, request, queryParamsDict);
}
-ScriptPromise Cache::add(ScriptState* scriptState, Request* request)
+ScriptPromise Cache::add(ScriptState* scriptState, Request* originalRequest)
{
- return rejectAsNotImplemented(scriptState);
+ TrackExceptionState exceptionState;
+ Request* request = Request::create(scriptState->executionContext(), originalRequest, exceptionState);
+ if (exceptionState.hadException()) {
+ // FIXME: We should throw the caught error.
+ return rejectForCacheError(scriptState, WebServiceWorkerCacheErrorNotFound);
+ }
+ return addImpl(scriptState, request);
}
ScriptPromise Cache::add(ScriptState* scriptState, const String& requestString)
{
- return rejectAsNotImplemented(scriptState);
+ TrackExceptionState exceptionState;
+ Request* request = Request::create(scriptState->executionContext(), requestString, exceptionState);
+ if (exceptionState.hadException()) {
+ // FIXME: We should throw the caught error.
+ return rejectForCacheError(scriptState, WebServiceWorkerCacheErrorNotFound);
+ }
+ return addImpl(scriptState, request);
}
ScriptPromise Cache::addAll(ScriptState* scriptState, const Vector<ScriptValue>& rawRequests)
{
+ // FIXME: Implement this.
return rejectAsNotImplemented(scriptState);
}
-ScriptPromise Cache::deleteFunction(ScriptState* scriptState, Request* request, const Dictionary& queryParams)
+ScriptPromise Cache::deleteFunction(ScriptState* scriptState, Request* originalRequest, const Dictionary& queryParamsDict)
{
- return rejectAsNotImplemented(scriptState);
+ TrackExceptionState exceptionState;
+ Request* request = Request::create(scriptState->executionContext(), originalRequest, exceptionState);
+ if (exceptionState.hadException()) {
+ // FIXME: We should throw the caught error.
+ return rejectForCacheError(scriptState, WebServiceWorkerCacheErrorNotFound);
+ }
+ return deleteImpl(scriptState, request, queryParamsDict);
}
-ScriptPromise Cache::deleteFunction(ScriptState* scriptState, const String& requestString, const Dictionary& queryParams)
+ScriptPromise Cache::deleteFunction(ScriptState* scriptState, const String& requestString, const Dictionary& queryParamsDict)
{
- return rejectAsNotImplemented(scriptState);
+ TrackExceptionState exceptionState;
+ Request* request = Request::create(scriptState->executionContext(), requestString, exceptionState);
+ if (exceptionState.hadException()) {
+ // FIXME: We should throw the caught error.
+ return rejectForCacheError(scriptState, WebServiceWorkerCacheErrorNotFound);
+ }
+ return deleteImpl(scriptState, request, queryParamsDict);
}
-ScriptPromise Cache::put(ScriptState* scriptState, Request* request, Response*)
+ScriptPromise Cache::put(ScriptState* scriptState, Request* originalRequest, Response* response)
{
- return rejectAsNotImplemented(scriptState);
+ TrackExceptionState exceptionState;
+ Request* request = Request::create(scriptState->executionContext(), originalRequest, exceptionState);
+ if (exceptionState.hadException()) {
+ // FIXME: We should throw the caught error.
+ return rejectForCacheError(scriptState, WebServiceWorkerCacheErrorNotFound);
+ }
+ return putImpl(scriptState, request, response);
}
-ScriptPromise Cache::put(ScriptState* scriptState, const String& requestString, Response*)
+ScriptPromise Cache::put(ScriptState* scriptState, const String& requestString, Response* response)
{
- return rejectAsNotImplemented(scriptState);
+ TrackExceptionState exceptionState;
+ Request* request = Request::create(scriptState->executionContext(), requestString, exceptionState);
+ if (exceptionState.hadException()) {
+ // FIXME: We should throw the caught error.
+ return rejectForCacheError(scriptState, WebServiceWorkerCacheErrorNotFound);
+ }
+ return putImpl(scriptState, request, response);
}
ScriptPromise Cache::keys(ScriptState* scriptState)
{
- return rejectAsNotImplemented(scriptState);
+ return keysImpl(scriptState);
+}
+
+ScriptPromise Cache::keys(ScriptState* scriptState, Request* originalRequest, const Dictionary& queryParamsDict)
+{
+ TrackExceptionState exceptionState;
+ Request* request = Request::create(scriptState->executionContext(), originalRequest, exceptionState);
+ if (exceptionState.hadException()) {
+ // FIXME: We should throw the caught error.
+ return rejectForCacheError(scriptState, WebServiceWorkerCacheErrorNotFound);
+ }
+ return keysImpl(scriptState, request, queryParamsDict);
+}
+
+ScriptPromise Cache::keys(ScriptState* scriptState, const String& requestString, const Dictionary& queryParamsDict)
+{
+ TrackExceptionState exceptionState;
+ Request* request = Request::create(scriptState->executionContext(), requestString, exceptionState);
+ if (exceptionState.hadException()) {
+ // FIXME: We should throw the caught error.
+ return rejectForCacheError(scriptState, WebServiceWorkerCacheErrorNotFound);
+ }
+ return keysImpl(scriptState, request, queryParamsDict);
+}
+
+Cache::Cache(WebServiceWorkerCache* webCache)
+ : m_webCache(adoptPtr(webCache)) { }
+
+ScriptPromise Cache::matchImpl(ScriptState* scriptState, Request* request, const Dictionary& queryParamsDict)
+{
+ WebServiceWorkerRequest webRequest;
+ request->populateWebServiceWorkerRequest(webRequest);
+
+ RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ const ScriptPromise promise = resolver->promise();
+ m_webCache->dispatchMatch(new CacheMatchCallbacks(resolver), webRequest, queryParamsFromDictionary(queryParamsDict));
+ return promise;
+}
+
+ScriptPromise Cache::matchAllImpl(ScriptState* scriptState, Request* request, const Dictionary& queryParamsDict)
+{
+ WebServiceWorkerRequest webRequest;
+ request->populateWebServiceWorkerRequest(webRequest);
+
+ RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ const ScriptPromise promise = resolver->promise();
+ m_webCache->dispatchMatchAll(new CacheWithResponsesCallbacks(resolver), webRequest, queryParamsFromDictionary(queryParamsDict));
+ return promise;
}
-ScriptPromise Cache::keys(ScriptState* scriptState, Request* request, const Dictionary& queryParams)
+ScriptPromise Cache::addImpl(ScriptState* scriptState, Request*)
{
+ // FIXME: Implement this.
return rejectAsNotImplemented(scriptState);
}
-ScriptPromise Cache::keys(ScriptState* scriptState, const String& requestString, const Dictionary& queryParams)
+ScriptPromise Cache::addAllImpl(ScriptState* scriptState, Vector<Request*>)
{
+ // FIXME: Implement this.
return rejectAsNotImplemented(scriptState);
}
@@ -113,8 +320,49 @@ PassRefPtrWillBeRawPtr<DOMException> Cache::domExceptionForCacheError(WebService
}
}
-Cache::Cache(WebServiceWorkerCache* webCache) : m_webCache(webCache)
+ScriptPromise Cache::deleteImpl(ScriptState* scriptState, Request* request, const Dictionary& queryParamsDict)
{
+ WebVector<WebServiceWorkerCache::BatchOperation> batchOperations(size_t(1));
+ batchOperations[0].operationType = WebServiceWorkerCache::OperationTypeDelete;
+ request->populateWebServiceWorkerRequest(batchOperations[0].request);
+ batchOperations[0].matchParams = queryParamsFromDictionary(queryParamsDict);
+
+ RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ const ScriptPromise promise = resolver->promise();
+ m_webCache->dispatchBatch(new CacheWithResponsesCallbacks(resolver), batchOperations);
+ return promise;
+}
+
+ScriptPromise Cache::putImpl(ScriptState* scriptState, Request* request, Response* response)
+{
+ WebVector<WebServiceWorkerCache::BatchOperation> batchOperations(size_t(1));
+ batchOperations[0].operationType = WebServiceWorkerCache::OperationTypePut;
+ request->populateWebServiceWorkerRequest(batchOperations[0].request);
+ response->populateWebServiceWorkerResponse(batchOperations[0].response);
+
+ RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ const ScriptPromise promise = resolver->promise();
+ m_webCache->dispatchBatch(new CacheWithResponsesCallbacks(resolver), batchOperations);
+ return promise;
+}
+
+ScriptPromise Cache::keysImpl(ScriptState* scriptState)
+{
+ RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ const ScriptPromise promise = resolver->promise();
+ m_webCache->dispatchKeys(new CacheWithRequestsCallbacks(resolver), 0, WebServiceWorkerCache::QueryParams());
+ return promise;
+}
+
+ScriptPromise Cache::keysImpl(ScriptState* scriptState, Request* request, const Dictionary& queryParamsDict)
+{
+ WebServiceWorkerRequest webRequest;
+ request->populateWebServiceWorkerRequest(webRequest);
+
+ RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ const ScriptPromise promise = resolver->promise();
+ m_webCache->dispatchKeys(new CacheWithRequestsCallbacks(resolver), 0, queryParamsFromDictionary(queryParamsDict));
+ return promise;
}
} // namespace blink
« no previous file with comments | « Source/modules/serviceworkers/Cache.h ('k') | Source/modules/serviceworkers/CacheTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698