Introducing the WebServiceWorkerCache.

Source/modules/serviceworkers/CacheStorage.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/serviceworkers/CacheStorage.h"
 
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "core/dom/DOMException.h"
@@ skipping 38 matching lines @@
 
 // FIXME: Consider using CallbackPromiseAdapter.
 class CacheStorageWithCacheCallbacks : public WebServiceWorkerCacheStorage::CacheStorageWithCacheCallbacks {
     WTF_MAKE_NONCOPYABLE(CacheStorageWithCacheCallbacks);
 public:
     explicit CacheStorageWithCacheCallbacks(PassRefPtr<ScriptPromiseResolver> resolver) : m_resolver(resolver) { }
     virtual ~CacheStorageWithCacheCallbacks() { }
 
     virtual void onSuccess(WebServiceWorkerCache* cache) OVERRIDE
     {
+        // FIXME: Remove this once content's WebServiceWorkerCache implementation has landed.
+        if (!cache) {
+            m_resolver->reject("not implemented");
+            return;
+        }
         m_resolver->resolve(Cache::fromWebServiceWorkerCache(cache));
         m_resolver.clear();
     }
 
     virtual void onError(WebServiceWorkerCacheError* reason) OVERRIDE
     {
         if (*reason == WebServiceWorkerCacheErrorNotFound)
-            m_resolver->resolve();
+            m_resolver->resolve(false);

[jsbell, 2014/09/04 00:28:08]

This makes caches.get("no such cache") resolve with `false` instead of
`undefined` (caught by asanka's tests, BTW). Spec says `undefined` in
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#ca...
unless I'm reading it wrong.

Is this intentional? Does this callback get used in different contexts where it
needs to return false?

[gavinp, 2014/09/04 19:47:33]

Not intentional. This was merge churn.

         else
             m_resolver->reject(Cache::domExceptionForCacheError(*reason));
         m_resolver.clear();
     }
 
 private:
     RefPtr<ScriptPromiseResolver> m_resolver;
 };
 
 // FIXME: Consider using CallbackPromiseAdapter.
@@ skipping 93 matching lines @@
 
     return promise;
 }
 
 CacheStorage::CacheStorage(WebServiceWorkerCacheStorage* webCacheStorage) : m_webCacheStorage(webCacheStorage)
 {
     ScriptWrappable::init(this);
 }
 
 } // namespace blink