Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 433663002: Remove the last remnant of <style scoped> (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
kouhei (in TOK)
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove the last remnant of <style scoped> This code was added while <style scoped> was still supported: http://trac.webkit.org/changeset/125955 The scoped attribute now does nothing anywhere else, so special behavior for editing doesn't make sense. TEST=LayoutTests/editing/execCommand/delete-selection-has-style.html BUG=379096 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M Source/core/editing/DeleteSelectionCommand.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLAttributeNames.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
philipj_slow
PTAL
6 years, 4 months ago (2014-08-04 13:01:53 UTC) #1
kouhei (in TOK)
lgtm
6 years, 4 months ago (2014-08-04 18:16:28 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-05 05:03:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/433663002/1
6 years, 4 months ago (2014-08-05 05:04:01 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 4 months ago (2014-08-05 05:50:04 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 06:12:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/11857)
6 years, 4 months ago (2014-08-05 06:12:43 UTC) #7
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 4 months ago (2014-08-05 07:34:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/433663002/1
6 years, 4 months ago (2014-08-05 07:35:36 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 07:53:49 UTC) #10
Message was sent while issue was closed.
Change committed as 179498

Powered by Google App Engine
This is Rietveld 408576698