Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: Source/core/inspector/PromiseTracker.cpp

Issue 433653003: Support Promises event-based instrumentation on backend. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/PromiseTracker.cpp
diff --git a/Source/core/inspector/PromiseTracker.cpp b/Source/core/inspector/PromiseTracker.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..14f6723950186309cbc632fc7cb73669b995f354
--- /dev/null
+++ b/Source/core/inspector/PromiseTracker.cpp
@@ -0,0 +1,151 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "core/inspector/PromiseTracker.h"
+
+#include "bindings/core/v8/ScriptCallStackFactory.h"
+#include "bindings/core/v8/ScriptState.h"
+
+namespace blink {
+
+struct PromiseTracker::PromiseDataWrapper {
aandrey 2014/08/06 16:31:31 should be just PromiseDataWrapper, wrapped into na
Alexandra Mikhaylova 2014/08/07 15:01:09 Done.
+ WTF_MAKE_NONCOPYABLE(PromiseDataWrapper);
+public:
+ PromiseDataWrapper(WeakPtr<PromiseData> data)
+ : m_data(data)
+ {
+ }
+
+ WeakPtr<PromiseData> m_data;
+
+ static void didRemovePromise(const v8::WeakCallbackData<v8::Object, PromiseDataWrapper>& data)
+ {
+ OwnPtr<PromiseDataWrapper> wrapper = adoptPtr(data.GetParameter());
+ WeakPtr<PromiseData> promiseData = wrapper->m_data;
+ if (!promiseData.get())
+ return;
+ PromiseTracker* tracker = promiseData->m_promiseTracker;
+ if (!tracker->isEnabled())
+ return;
+ tracker->didRemovePromise(promiseData);
+ }
+};
+
+PromiseTracker::PromiseData::PromiseData(v8::Isolate* isolate, v8::Handle<v8::Object> promise, v8::Handle<v8::Object> parentPromise, int status, PromiseTracker* tracker, bool captureStack)
+ : m_promiseTracker(tracker)
+ , m_promiseHash(promise->GetIdentityHash())
+ , m_promise(isolate, promise)
+ , m_parentPromise(isolate, parentPromise)
+ , m_status(status)
+ , m_weakPtrFactory(this)
+{
+ if (captureStack) {
+ v8::Handle<v8::StackTrace> stackTrace(v8::StackTrace::CurrentStackTrace(isolate, 1));
+ RefPtrWillBeRawPtr<ScriptCallStack> stack = createScriptCallStack(stackTrace, 1, isolate);
+ if (stack->size())
+ m_callFrame = stack->at(0);
+ }
+ PromiseDataWrapper* wrapper = new PromiseDataWrapper(m_weakPtrFactory.createWeakPtr());
+ m_promise.setWeak(wrapper, &PromiseTracker::PromiseDataWrapper::didRemovePromise);
+}
+
+void PromiseTracker::enable()
+{
+ m_isEnabled = true;
+}
+
+void PromiseTracker::disable()
+{
+ m_isEnabled = false;
+ clear();
+}
+
+void PromiseTracker::clear()
+{
+ m_promiseDataMap.clear();
+}
+
+PromiseTracker::PromiseDataVector* PromiseTracker::promiseVector(int promiseHash)
+{
+ ASSERT(isEnabled());
aandrey 2014/08/06 16:31:31 redundant?
Alexandra Mikhaylova 2014/08/07 15:01:09 Removed.
+
+ PromiseDataMap::iterator it = m_promiseDataMap.find(promiseHash);
+ if (it != m_promiseDataMap.end())
+ return &it->value;
+ return &m_promiseDataMap.add(promiseHash, PromiseDataVector()).storedValue->value;
+}
+
+void PromiseTracker::didReceiveV8PromiseEvent(ScriptState* scriptState, v8::Handle<v8::Object> promise, v8::Handle<v8::Value> parentPromise, int status)
+{
+ ASSERT(isEnabled());
+
+ if (status != 0) {
+ didUpdatePromiseStatus(scriptState, promise, status);
+ } else if (parentPromise->IsObject()) {
+ didUpdatePromiseParent(scriptState, promise, parentPromise->ToObject());
+ } else {
+ didCreatePromise(scriptState, promise);
+ }
+}
+
+void PromiseTracker::didCreatePromise(ScriptState* scriptState, v8::Handle<v8::Object> promise)
+{
+ PromiseDataVector* vector = promiseVector(promise->GetIdentityHash());
+ vector->append(adoptRef(new PromiseData(scriptState->isolate(), promise, v8::Handle<v8::Object>(), 0, this, true)));
+}
+
+void PromiseTracker::didUpdatePromiseParent(ScriptState* scriptState, v8::Handle<v8::Object> promise, v8::Handle<v8::Object> parentPromise)
+{
+ PromiseDataVector* vector = promiseVector(promise->GetIdentityHash());
+ bool found = false;
+ for (size_t index = 0; index < vector->size(); ++index) {
+ RefPtr<PromiseData> data = vector->at(index);
+ if (data->m_promise == promise) {
+ found = true;
+ data->m_parentPromise.set(scriptState->isolate(), parentPromise);
+ break;
+ }
+ }
+ if (!found)
+ vector->append(adoptRef(new PromiseData(scriptState->isolate(), promise, parentPromise, 0, this)));
+}
+
+void PromiseTracker::didUpdatePromiseStatus(ScriptState* scriptState, v8::Handle<v8::Object> promise, int status)
+{
+ PromiseDataVector* vector = promiseVector(promise->GetIdentityHash());
+ bool found = false;
+ for (size_t index = 0; index < vector->size(); ++index) {
+ RefPtr<PromiseData> data = vector->at(index);
+ if (data->m_promise == promise) {
+ found = true;
+ data->m_status = status;
+ break;
+ }
+ }
+ if (!found)
+ vector->append(adoptRef(new PromiseData(scriptState->isolate(), promise, v8::Handle<v8::Object>(), status, this)));
+}
+
+void PromiseTracker::didRemovePromise(WeakPtr<PromiseData>& promiseData)
aandrey 2014/08/06 16:31:31 don't use WeakPtr here
Alexandra Mikhaylova 2014/08/07 15:01:09 Done.
+{
+ ASSERT(isEnabled());
aandrey 2014/08/06 16:31:31 remove
Alexandra Mikhaylova 2014/08/07 15:01:09 Done.
+
+ int promiseHash = promiseData->m_promiseHash;
+ PromiseDataVector* vector = promiseVector(promiseHash);
+ ASSERT(vector->size() >= 1);
+ bool found = false;
+ for (size_t index = 0; index < vector->size(); ++index) {
+ RefPtr<PromiseData> data = vector->at(index);
+ if (data->m_promise == promiseData->m_promise) {
+ found = true;
aandrey 2014/08/06 16:31:31 too much copy-pasted code duplication, this is a n
Alexandra Mikhaylova 2014/08/07 15:01:09 Refactored the methods.
+ vector->remove(index);
+ break;
+ }
+ }
+ if (vector->size() == 0)
+ m_promiseDataMap.remove(promiseHash);
+}
+
+} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698