Source/core/inspector/InspectorDebuggerAgent.h - Issue 433653003: Support Promises event-based instrumentation on backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorDebuggerAgent.h

Issue 433653003: Support Promises event-based instrumentation on backend. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address comments + REBASE Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptDebugServer.cpp ('K') | « Source/core/core.gypi ('k') | Source/core/inspector/InspectorDebuggerAgent.cpp » ('j') | Source/core/inspector/PromiseTracker.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorDebuggerAgent.h

diff --git a/Source/core/inspector/InspectorDebuggerAgent.h b/Source/core/inspector/InspectorDebuggerAgent.h

index 56477d23ef2e7f231958478f785ad2727f0cc230..70e5c25d3d9d38e3d8fe182d8ece0d63fd0414e0 100644

--- a/Source/core/inspector/InspectorDebuggerAgent.h

+++ b/Source/core/inspector/InspectorDebuggerAgent.h

@@ -37,6 +37,7 @@

#include "core/inspector/ConsoleAPITypes.h"

#include "core/inspector/InjectedScript.h"

#include "core/inspector/InspectorBaseAgent.h"

+#include "core/inspector/PromiseTracker.h"

#include "core/inspector/ScriptBreakpoint.h"

#include "core/inspector/ScriptDebugListener.h"

#include "wtf/Forward.h"

@@ -225,6 +226,7 @@ private:

virtual void didParseSource(const String& scriptId, const Script&, CompileResult) OVERRIDE FINAL;

virtual void didReceiveV8AsyncTaskEvent(ExecutionContext*, const String& eventType, const String& eventName, int id) OVERRIDE FINAL;

+ virtual void didReceiveV8PromiseEvent(ScriptState*, const ScopedPersistent<v8::Object>& promise, const ScopedPersistent<v8::Object>& parentPromise, int status) OVERRIDE FINAL;

aandrey 2014/08/04 16:58:47 v8::* not allowed here

Alexandra Mikhaylova 2014/08/06 13:28:39 We'll keep it here for now as there's no quick alt

void setPauseOnExceptionsImpl(ErrorString*, int);

@@ -263,6 +265,7 @@ private:

bool m_skipAllPauses;

OwnPtr<ScriptRegexp> m_cachedSkipStackRegExp;

AsyncCallStackTracker m_asyncCallStackTracker;

+ PromiseTracker m_promiseTracker;

};

} // namespace blink

« Source/bindings/core/v8/ScriptDebugServer.cpp ('K') | « Source/core/core.gypi ('k') | Source/core/inspector/InspectorDebuggerAgent.cpp » ('j') | Source/core/inspector/PromiseTracker.h » ('J')