Support Promises event-based instrumentation on backend.

Source/bindings/core/v8/ScriptDebugServer.cpp

 /*
  * Copyright (c) 2010-2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 453 matching lines @@
 void ScriptDebugServer::handleV8DebugEvent(const v8::Debug::EventDetails& eventDetails)
 {
     v8::DebugEvent event = eventDetails.GetEvent();
 
     if (event == v8::BreakForCommand) {
         ClientDataImpl* data = static_cast<ClientDataImpl*>(eventDetails.GetClientData());
         data->task()->run();
         return;
     }
 
-    if (event != v8::AsyncTaskEvent && event != v8::Break && event != v8::Exception && event != v8::AfterCompile && event != v8::BeforeCompile && event != v8::CompileError)
+    if (event != v8::AsyncTaskEvent && event != v8::Break && event != v8::Exception && event != v8::AfterCompile && event != v8::BeforeCompile && event != v8::CompileError && event != v8::PromiseEvent)
         return;
 
     v8::Handle<v8::Context> eventContext = eventDetails.GetEventContext();
     ASSERT(!eventContext.IsEmpty());
 
     ScriptDebugListener* listener = getDebugListenerForContext(eventContext);
     if (listener) {
         v8::HandleScope scope(m_isolate);
         v8::Handle<v8::Object> debuggerScript = m_debuggerScript.newLocal(m_isolate);
         if (event == v8::BeforeCompile) {
@@ skipping 11 matching lines @@
             v8::Handle<v8::Value> exception = callInternalGetterFunction(eventData, "exception", m_isolate);
             handleProgramBreak(ScriptState::from(eventContext), eventDetails.GetExecutionState(), exception, v8::Handle<v8::Array>());
         } else if (event == v8::Break) {
             v8::Handle<v8::Function> getBreakpointNumbersFunction = v8::Local<v8::Function>::Cast(debuggerScript->Get(v8AtomicString(m_isolate, "getBreakpointNumbers")));
             v8::Handle<v8::Value> argv[] = { eventDetails.GetEventData() };
             v8::Handle<v8::Value> hitBreakpoints = V8ScriptRunner::callInternalFunction(getBreakpointNumbersFunction, debuggerScript, WTF_ARRAY_LENGTH(argv), argv, m_isolate);
             ASSERT(hitBreakpoints->IsArray());
             handleProgramBreak(ScriptState::from(eventContext), eventDetails.GetExecutionState(), v8::Handle<v8::Value>(), hitBreakpoints.As<v8::Array>());
         } else if (event == v8::AsyncTaskEvent) {
             handleV8AsyncTaskEvent(listener, ScriptState::from(eventContext), eventDetails.GetExecutionState(), eventDetails.GetEventData());
+        } else if (event == v8::PromiseEvent) {
+            handleV8PromiseEvent(listener, ScriptState::from(eventContext), eventDetails.GetExecutionState(), eventDetails.GetEventData());
         }
     }
 }
 
 void ScriptDebugServer::handleV8AsyncTaskEvent(ScriptDebugListener* listener, ScriptState* pausedScriptState, v8::Handle<v8::Object> executionState, v8::Handle<v8::Object> eventData)
 {
     String type = toCoreStringWithUndefinedOrNullCheck(callInternalGetterFunction(eventData, "type", m_isolate));
     String name = toCoreStringWithUndefinedOrNullCheck(callInternalGetterFunction(eventData, "name", m_isolate));
     int id = callInternalGetterFunction(eventData, "id", m_isolate)->ToInteger()->Value();
 
     // FIXME: Remove when not needed.
     if (name == "Promise.Resolved")
         name = "Promise.resolve";
     else if (name == "Promise.Rejected")
         name = "Promise.reject";
 
     m_pausedScriptState = pausedScriptState;
     m_executionState = executionState;
     listener->didReceiveV8AsyncTaskEvent(pausedScriptState->executionContext(), type, name, id);
     m_pausedScriptState.clear();
     m_executionState.Clear();
 }
 
+void ScriptDebugServer::handleV8PromiseEvent(ScriptDebugListener* listener, ScriptState* pausedScriptState, v8::Handle<v8::Object> executionState, v8::Handle<v8::Object> eventData)
+{
+    m_pausedScriptState = pausedScriptState;
+    m_executionState = executionState;
+    v8::Isolate* isolate = m_pausedScriptState->isolate();
+    v8::Handle<v8::Value> argv[] = { eventData };
+    v8::Local<v8::Object> promiseDetails = callDebuggerMethod("getPromiseDetails", 1, argv)->ToObject();
+    ScopedPersistent<v8::Object> promise(isolate, promiseDetails->Get(v8AtomicString(m_isolate, "promise"))->ToObject());
+    int status = static_cast<int>(promiseDetails->Get(v8AtomicString(m_isolate, "status"))->ToInteger()->Value());

[aandrey, 2014/08/04 16:58:47]

why static_cast<int>?

[Alexandra Mikhaylova, 2014/08/06 13:28:38]

Removed it.

+    v8::Handle<v8::Value> parentPromiseHandle = promiseDetails->Get(v8AtomicString(m_isolate, "parentPromise"));
+    ScopedPersistent<v8::Object> parentPromise(isolate, parentPromiseHandle->IsUndefined() ? v8::Handle<v8::Object>() : parentPromiseHandle->ToObject());

[aandrey, 2014/08/04 16:58:47]

use IsObject() instead of IsUndefined()

[Alexandra Mikhaylova, 2014/08/06 13:28:39]

Done.

+    listener->didReceiveV8PromiseEvent(pausedScriptState, promise, parentPromise, status);

[aandrey, 2014/08/04 16:58:47]

nit: line break before, assign m_pausedScriptState and m_executionState just
before this line, as in lines 523-528

[Alexandra Mikhaylova, 2014/08/06 13:28:38]

Done.

+    m_pausedScriptState.clear();
+    m_executionState.Clear();
+}
+
 void ScriptDebugServer::dispatchDidParseSource(ScriptDebugListener* listener, v8::Handle<v8::Object> object, CompileResult compileResult)
 {
     v8::Handle<v8::Value> id = object->Get(v8AtomicString(m_isolate, "id"));
     ASSERT(!id.IsEmpty() && id->IsInt32());
     String sourceID = String::number(id->Int32Value());
 
     ScriptDebugListener::Script script;
     script.url = toCoreStringWithUndefinedOrNullCheck(object->Get(v8AtomicString(m_isolate, "name")));
     script.sourceURL = toCoreStringWithUndefinedOrNullCheck(object->Get(v8AtomicString(m_isolate, "sourceURL")));
     script.sourceMappingURL = toCoreStringWithUndefinedOrNullCheck(object->Get(v8AtomicString(m_isolate, "sourceMappingURL")));
@@ skipping 133 matching lines @@
 {
     return PassOwnPtr<ScriptSourceCode>();
 }
 
 String ScriptDebugServer::preprocessEventListener(LocalFrame*, const String& source, const String& url, const String& functionName)
 {
     return source;
 }
 
 } // namespace blink