Use the same OWNER rules for BUILD.gn files as for .gyp files in ui/

Use the same OWNER rules for BUILD.gn files as for .gyp files in ui/

BUG=None
TEST=None
R=brettw
TBR=sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287279

[pkotwicz, 2014-07-31 18:33:57]

Brett, PTAL.

I am not too sure how far along gn is. If it is far along enough that there does
not need to be a dedicated reviewer for trivial additions to a build-target, it
would be nice not to need an extra reviewer just for BUILD.gn changes

e.g. If I were to add a file to ui/base/x,
I would like to only need a review from an OWNER of ui/base/x even though
ui/base/BUILD.gn is not in ui/base/x

[brettw, 2014-07-31 20:10:24]

On 2014/07/31 18:33:57, pkotwicz wrote:
> Brett, PTAL.
> 
> I am not too sure how far along gn is. If it is far along enough that there
does
> not need to be a dedicated reviewer for trivial additions to a build-target,
it
> would be nice not to need an extra reviewer just for BUILD.gn changes
> 
> e.g. If I were to add a file to ui/base/x,
> I would like to only need a review from an OWNER of ui/base/x even though
> ui/base/BUILD.gn is not in ui/base/x

This is actually a bug in the script, where it recursively applies all filters,
so the "BUILD.gn" at the root level recursively applies to all other directories
as well. There's another script (maybe the presubmit step on the bots) doesn't
work this way. The best solution would be to fix git cl to know about this. Do
you want to have a look at git-cl to see if there's an obvious fix? That would
be much better than doing this, which doesn't solve the problem for any other
subproject.

[pkotwicz, 2014-07-31 20:41:50]

The OWNERS file at the root level sets brettw@ as an OWNER for all BUILD.gn
files.

I am trying to make it such that if I get OWNERS approval for a new file from an
OWNER of ui/base/x that I do not need to get approval from a different OWNER
(e.g. brettw@) in order to change ui/base/BUILD.gn (I do not need to get
approval from a different OWNER in order to change ui_base.gyp)

[brettw, 2014-07-31 21:18:56]

If one owner applies a change, it should apply to all files that that that owner
covers, so it somebody is an owner of a directory, their ownership should cover
the BUILD.gn file in that directory.

Are you seeing behavior to the contrary?

[pkotwicz, 2014-08-01 03:43:38]

Currently, anyone can sign off on gyp files in ui/ Note: "per-file *.gyp*=*". I
want anyone to be able to sign off on changes to BUILD.gn files in UI too.

[brettw, 2014-08-03 22:12:26]

Oh, I see. Sorry I misunderstood what was going on.

LGTM

[pkotwicz, 2014-08-04 01:07:51]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-08-04 01:08:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/433603006/1

[commit-bot: I haz the power, 2014-08-04 02:16:26]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[commit-bot: I haz the power, 2014-08-04 02:37:48]

Change committed as 287279