Disentangle repaint-after-compositing from updateLayerPositionsAfterLayout

LayoutTests/platform/mac/fast/repaint/float-overflow-expected.txt

Index: LayoutTests/platform/mac/fast/repaint/float-overflow-expected.txt
diff --git a/LayoutTests/platform/mac/fast/repaint/float-overflow-expected.txt b/LayoutTests/platform/mac/fast/repaint/float-overflow-expected.txt
index 0234e107522e05d8268f8aebc74dbdd34bf65a5d..f5abc63114b839196a82d1ee611bcdcd3648271d 100644
--- a/LayoutTests/platform/mac/fast/repaint/float-overflow-expected.txt
+++ b/LayoutTests/platform/mac/fast/repaint/float-overflow-expected.txt
@@ -8,6 +8,22 @@
       "repaintRects": [
         [67, 426, 50, 10],
         [67, 420, 50, 10],
+        [67, 374, 46, 12],
+        [67, 368, 46, 12],
+        [67, 335, 46, 12],
+        [67, 329, 46, 12],
+        [67, 296, 46, 12],
+        [67, 290, 46, 12],
+        [66, 297, 44, 18],
+        [66, 296, 45, 19],
+        [66, 294, 47, 21],
+        [66, 291, 44, 18],
+        [66, 290, 45, 19],
+        [66, 288, 47, 21],
+        [63, 21, 54, 18],
+        [63, 21, 42, 18],
+        [63, 15, 54, 18],
+        [63, 15, 42, 18],

[Julien - ping for review, 2014/08/01 23:50:05]

This is my biggest concern with this patch. The code is fine and I have no
objection to it.

While I don't think the extra invalidations are costing us a lot, it's still not
correct to generate tons of extra redundant invalidations. We have tried to
reduce them as we implemented repaint-after-layout and it's a clear regression
from that perspective.

If the patch was solving a correctness bug, a case could be made for the extra
invalidations. However this change is a refactoring so it's a pure regression
from my perspective.

         [61, 459, 62, 22],
         [61, 453, 62, 22],
         [61, 420, 62, 22],
@@ -16,27 +32,75 @@
         [61, 282, 58, 28],
         [61, 15, 62, 24],
         [61, 9, 62, 24],
+        [59, 543, 40, 20],
+        [59, 543, 40, 18],
         [59, 537, 64, 36],
+        [59, 537, 40, 20],
+        [59, 537, 40, 18],
         [59, 531, 64, 36],
+        [59, 504, 58, 18],
+        [59, 504, 40, 18],
         [59, 498, 64, 24],
+        [59, 498, 58, 18],
+        [59, 498, 40, 18],
         [59, 492, 64, 24],
         [59, 465, 58, 18],
+        [59, 465, 40, 18],
         [59, 459, 58, 18],
+        [59, 459, 40, 18],
         [59, 426, 40, 18],
         [59, 420, 40, 18],
+        [59, 255, 40, 18],
+        [59, 255, 40, 18],
         [59, 249, 64, 24],
+        [59, 249, 40, 18],
+        [59, 249, 40, 18],
         [59, 243, 64, 24],
+        [59, 216, 58, 18],
+        [59, 216, 40, 18],
         [59, 210, 64, 24],
+        [59, 210, 58, 18],
+        [59, 210, 40, 18],
         [59, 204, 64, 24],
+        [59, 177, 58, 18],
+        [59, 177, 40, 18],
         [59, 171, 64, 24],
+        [59, 171, 58, 18],
+        [59, 171, 40, 18],
         [59, 165, 64, 24],
+        [59, 138, 58, 18],
+        [59, 138, 48, 18],
         [59, 132, 64, 24],
+        [59, 132, 58, 18],
+        [59, 132, 48, 18],
         [59, 126, 64, 24],
+        [58, 375, 52, 18],
+        [58, 374, 53, 19],
+        [58, 372, 55, 21],
+        [58, 369, 52, 18],
+        [58, 368, 53, 19],
+        [58, 366, 61, 28],
+        [58, 366, 55, 21],
+        [58, 360, 61, 28],
+        [58, 336, 52, 18],
+        [58, 335, 53, 19],
+        [58, 333, 55, 21],
+        [58, 330, 52, 18],
+        [58, 329, 53, 19],
         [58, 327, 61, 28],
+        [58, 327, 55, 21],
         [58, 321, 61, 28],
+        [57, 99, 60, 18],
+        [57, 99, 42, 18],
         [57, 93, 66, 24],
+        [57, 93, 60, 18],
+        [57, 93, 42, 18],
         [57, 87, 66, 24],
+        [57, 60, 60, 18],
+        [57, 60, 48, 18],
         [57, 54, 66, 24],
+        [57, 54, 60, 18],
+        [57, 54, 48, 18],
         [57, 48, 66, 24],
         [11, 366, 778, 28],
         [11, 360, 778, 28]