Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: Source/core/rendering/RenderLayer.cpp

Issue 433603004: Disentangle repaint-after-compositing from updateLayerPositionsAfterLayout (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderLayer.h ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
253 m_clipper.clearClipRectsIncludingDescendants(); 253 m_clipper.clearClipRectsIncludingDescendants();
254 254
255 // FIXME: Remove incremental compositing updates after fixing the chicken/eg g issues 255 // FIXME: Remove incremental compositing updates after fixing the chicken/eg g issues
256 // https://code.google.com/p/chromium/issues/detail?id=343756 256 // https://code.google.com/p/chromium/issues/detail?id=343756
257 DisableCompositingQueryAsserts disabler; 257 DisableCompositingQueryAsserts disabler;
258 updateLayerPositionRecursive(flags); 258 updateLayerPositionRecursive(flags);
259 } 259 }
260 260
261 void RenderLayer::updateLayerPositionRecursive(UpdateLayerPositionsFlags flags) 261 void RenderLayer::updateLayerPositionRecursive(UpdateLayerPositionsFlags flags)
262 { 262 {
263 if (updateLayerPosition()) 263 updateLayerPosition();
264 flags |= ForceMayNeedPaintInvalidation;
265
266 if (flags & ForceMayNeedPaintInvalidation)
267 m_renderer->setMayNeedPaintInvalidation(true);
268 264
269 if (hasOverflowControls()) { 265 if (hasOverflowControls()) {
270 // FIXME: We should figure out the right time to position the overflow c ontrols. 266 // FIXME: We should figure out the right time to position the overflow c ontrols.
271 // This call appears to be necessary to pass some layout test that use E ventSender, 267 // This call appears to be necessary to pass some layout test that use E ventSender,
272 // presumably because the normal time to position the controls is during paint. We 268 // presumably because the normal time to position the controls is during paint. We
273 // probably shouldn't position the overflow controls during paint either ... 269 // probably shouldn't position the overflow controls during paint either ...
274 scrollableArea()->positionOverflowControls(IntSize()); 270 scrollableArea()->positionOverflowControls(IntSize());
275 } 271 }
276 272
277 updateDescendantDependentFlags(); 273 updateDescendantDependentFlags();
(...skipping 3521 matching lines...) Expand 10 before | Expand all | Expand 10 after
3799 } 3795 }
3800 } 3796 }
3801 3797
3802 void showLayerTree(const blink::RenderObject* renderer) 3798 void showLayerTree(const blink::RenderObject* renderer)
3803 { 3799 {
3804 if (!renderer) 3800 if (!renderer)
3805 return; 3801 return;
3806 showLayerTree(renderer->enclosingLayer()); 3802 showLayerTree(renderer->enclosingLayer());
3807 } 3803 }
3808 #endif 3804 #endif
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderLayer.h ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698