Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1828)

Unified Diff: src/gpu/gl/GrGLCaps.h

Issue 433603002: FBFetch refactor + arm support (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: comment cleanup Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/gl/GrGLCaps.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/gl/GrGLCaps.h
diff --git a/src/gpu/gl/GrGLCaps.h b/src/gpu/gl/GrGLCaps.h
index ccf04fd7ba5a3d668ef5d2671d0defc5af6ea6b6..887e2e9e2ad0067a43902ee868d3dfe6ecae5b0e 100644
--- a/src/gpu/gl/GrGLCaps.h
+++ b/src/gpu/gl/GrGLCaps.h
@@ -68,16 +68,6 @@ public:
kLast_MSFBOType = kES_EXT_MsToTexture_MSFBOType
};
- enum FBFetchType {
- kNone_FBFetchType,
- /** GL_EXT_shader_framebuffer_fetch */
- kEXT_FBFetchType,
- /** GL_NV_shader_framebuffer_fetch */
- kNV_FBFetchType,
-
- kLast_FBFetchType = kNV_FBFetchType
- };
-
enum InvalidateFBType {
kNone_InvalidateFBType,
kDiscard_InvalidateFBType, //<! glDiscardFramebuffer()
@@ -174,7 +164,16 @@ public:
kES_EXT_MsToTexture_MSFBOType == fMSFBOType;
}
- FBFetchType fbFetchType() const { return fFBFetchType; }
+ /**
+ * Some helper functions for encapsulating various extensions to read FB Buffer on openglES
+ *
+ * TODO On desktop opengl 4.2+ we can achieve something similar to this effect
+ */
+ bool fbFetchSupport() const { return fFBFetchSupport; }
+
+ const char* fbFetchColorName() const { return fFBFetchColorName; }
+
+ const char* fbFetchExtensionString() const { return fFBFetchExtensionString; }
InvalidateFBType invalidateFBType() const { return fInvalidateFBType; }
@@ -340,7 +339,6 @@ private:
int fMaxFixedFunctionTextureCoords;
MSFBOType fMSFBOType;
- FBFetchType fFBFetchType;
InvalidateFBType fInvalidateFBType;
MapBufferType fMapBufferType;
LATCAlias fLATCAlias;
@@ -363,6 +361,10 @@ private:
bool fIsCoreProfile : 1;
bool fFullClearIsFree : 1;
bool fDropsTileOnZeroDivide : 1;
+ bool fFBFetchSupport : 1;
+
+ const char* fFBFetchColorName;
+ const char* fFBFetchExtensionString;
typedef GrDrawTargetCaps INHERITED;
};
« no previous file with comments | « no previous file | src/gpu/gl/GrGLCaps.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698