Issue 433533003: Merge 285580 "Currently, destroying a ui::TouchEvent removes its..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 433533003: Merge 285580 "Currently, destroying a ui::TouchEvent removes its..." (Closed)

Created:
6 years, 4 months ago by tdresser

Modified:
6 years, 4 months ago

Reviewers:
tdresser

CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org, tdresser+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/2062/src/

Project:
chromium

Visibility:
Public.

More Reviews

Description

Merge 285580 "Currently, destroying a ui::TouchEvent removes its..." > Currently, destroying a ui::TouchEvent removes its tracking id from the slot mapping. Because MenuEventDispatcher::DispatchEvent was creating > (and destroying) a touch event, the tracking id was being > removed too early. > > This patch refcounts the tracking ids, so the tracking id won't be removed until it should be. > > BUG=394437 > > Review URL: https://codereview.chromium.org/400213002 TBR=tdresser@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286563

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+110 lines, -2 lines)			Patch
M	ui/events/cocoa/events_mac.mm	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/events/event.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/events/event_utils.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/events/events_stub.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	ui/events/ozone/events_ozone.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/events/win/events_win.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/events/x/events_x.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	ui/events/x/events_x_unittest.cc	View	1 chunk	+59 lines, -0 lines	0 comments	Download
M	ui/events/x/touch_factory_x11.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	ui/events/x/touch_factory_x11.cc	View	1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r286563.

Expand Messages | Collapse Messages