Add blacklist incidents to incident reporting service.

Report on blacklist incidents.

BUG=394352
TEST=NONE

Committed: https://crrev.com/64df1add6f9fe6e26f559604feec50e84acf1ae4
Cr-Commit-Position: refs/heads/master@{#292033}

[robertshield, 2014-08-22 03:58:34]

Matt, please could you take a look at all of the safe_browsing related code,
Cait please could you take a look at the elf code. Thanks!

[Cait (Slow), 2014-08-22 15:07:13]

Just to confirm: the code being removed from ELF was not in use anywhere,
correct? If so chrome_elf bits lgtm.

[robertshield, 2014-08-25 15:18:45]

On 2014/08/22 15:07:13, Cait Phillips wrote:
> Just to confirm: the code being removed from ELF was not in use anywhere,
> correct? If so chrome_elf bits lgtm.

@Cait: that's correct.

@Matt: ping! :)

[mattm, 2014-08-26 00:36:02]

https://codereview.chromium.org/433513008/diff/160001/chrome/browser/safe_bro...
File
chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc
(right):

https://codereview.chromium.org/433513008/diff/160001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc:55:
blacklist_load->set_path(base::WideToUTF8(*module_iter));
Should this use path sanitizer?

https://codereview.chromium.org/433513008/diff/160001/chrome/browser/safe_bro...
File
chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident_handlers_unittest.cc
(right):

https://codereview.chromium.org/433513008/diff/160001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident_handlers_unittest.cc:41:
// Tests that GetDigest returns the same value for the same incident.
fix comment

https://codereview.chromium.org/433513008/diff/160001/chrome/chrome_tests_uni...
File chrome/chrome_tests_unit.gypi (right):

https://codereview.chromium.org/433513008/diff/160001/chrome/chrome_tests_uni...
chrome/chrome_tests_unit.gypi:1226:
'browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win_unittest.cc',
sorting

[robertshield, 2014-08-26 03:09:23]

Thanks Matt, PTAL.

https://codereview.chromium.org/433513008/diff/160001/chrome/browser/safe_bro...
File
chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc
(right):

https://codereview.chromium.org/433513008/diff/160001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc:55:
blacklist_load->set_path(base::WideToUTF8(*module_iter));
On 2014/08/26 00:36:01, mattm wrote:
> Should this use path sanitizer?

Yes, it should. Done.

https://codereview.chromium.org/433513008/diff/160001/chrome/browser/safe_bro...
File
chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident_handlers_unittest.cc
(right):

https://codereview.chromium.org/433513008/diff/160001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident_handlers_unittest.cc:41:
// Tests that GetDigest returns the same value for the same incident.
On 2014/08/26 00:36:02, mattm wrote:
> fix comment

Done.

https://codereview.chromium.org/433513008/diff/160001/chrome/chrome_tests_uni...
File chrome/chrome_tests_unit.gypi (right):

https://codereview.chromium.org/433513008/diff/160001/chrome/chrome_tests_uni...
chrome/chrome_tests_unit.gypi:1226:
'browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win_unittest.cc',
On 2014/08/26 00:36:02, mattm wrote:
> sorting

Done.

[mattm, 2014-08-26 18:19:05]

lgtm

[robertshield, 2014-08-26 21:22:19]

The CQ bit was checked by robertshield@chromium.org

[commit-bot: I haz the power, 2014-08-26 21:23:47]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/robertshield@chromium.org/433513008/18...

[commit-bot: I haz the power, 2014-08-26 23:42:35]

Committed patchset #5 (180001) as 8b9d6a9aa55b2cb03085a130fbe2d2f0af24397f

[commit-bot: I haz the power, 2014-09-10 02:47:26]

Patchset 5 (id:??) landed as
https://crrev.com/64df1add6f9fe6e26f559604feec50e84acf1ae4
Cr-Commit-Position: refs/heads/master@{#292033}