Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc

Issue 433513005: Pass ServiceProvider thru ViewManagerService::Embed() allowing embedder & embeddee to expose servic… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc
diff --git a/mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc b/mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc
index 2e0b8a52a789e6a6805194abae68f52d3998fe17..f56a060e222ffb6fdf9ca9c793696c7aa0d41f67 100644
--- a/mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc
+++ b/mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc
@@ -10,6 +10,8 @@
#include "mojo/public/cpp/application/application_connection.h"
#include "mojo/public/cpp/application/application_delegate.h"
#include "mojo/public/cpp/application/application_impl.h"
+#include "mojo/public/cpp/application/service_provider_impl.h"
+#include "mojo/public/interfaces/application/service_provider.mojom.h"
#include "mojo/service_manager/service_manager.h"
#include "mojo/services/public/cpp/view_manager/lib/node_private.h"
#include "mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h"
@@ -72,7 +74,10 @@ class ConnectServiceLoader : public ServiceLoader,
}
// Overridden from ViewManagerDelegate:
- virtual void OnEmbed(ViewManager* view_manager, Node* root) OVERRIDE {
+ virtual void OnEmbed(ViewManager* view_manager,
+ Node* root,
+ ServiceProviderImpl* exported_services,
+ scoped_ptr<ServiceProvider> imported_services) OVERRIDE {
callback_.Run(view_manager, root);
}
virtual void OnViewManagerDisconnected(ViewManager* view_manager) OVERRIDE {}
@@ -327,11 +332,6 @@ class ViewManagerTest : public testing::Test {
return GetLoadedViewManager();
}
- // TODO(beng): remove these methods once all the tests are migrated.
- void DestroyViewManager1() {}
- ViewManager* view_manager_1() { return NULL; }
- ViewManager* view_manager_2() { return NULL; }
-
ViewManager* GetLoadedViewManager() {
ViewManager* view_manager = loaded_view_manager_;
loaded_view_manager_ = NULL;
@@ -368,8 +368,10 @@ class ViewManagerTest : public testing::Test {
bool EmbedRoot(ViewManagerInitService* view_manager_init,
const std::string& url) {
bool result = false;
+ ServiceProviderPtr sp;
+ BindToProxy(new ServiceProviderImpl, &sp);
view_manager_init->Embed(
- url,
+ url, sp.Pass(),
base::Bind(&ViewManagerTest::EmbedRootCallback, base::Unretained(this),
&result));
RunRunLoop();
« no previous file with comments | « mojo/services/public/cpp/view_manager/node.h ('k') | mojo/services/public/cpp/view_manager/view_manager_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698