Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 433513004: Update NEON compiler defines to use SK_ prefix (Closed)

Created:
6 years, 4 months ago by djsollen
Modified:
6 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Update NEON compiler defines to use SK_ prefix BUG=skia:2785 Committed: https://skia.googlesource.com/skia/+/21769c52491b4e1c91cf7461af535aff2a1a18f7

Patch Set 1 #

Patch Set 2 : fix ios #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M gyp/common_variables.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPreConfig.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
djsollen
This will require a change to first land in chromium to setup the new defines.
6 years, 4 months ago (2014-07-31 15:46:37 UTC) #1
mtklein
lgtm
6 years, 4 months ago (2014-07-31 15:50:52 UTC) #2
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 4 months ago (2014-08-01 12:19:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/433513004/1
6 years, 4 months ago (2014-08-01 12:20:51 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 12:32:39 UTC) #5
Message was sent while issue was closed.
Change committed as 21769c52491b4e1c91cf7461af535aff2a1a18f7

Powered by Google App Engine
This is Rietveld 408576698