Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 433503003: Correct Android FontMgr use of ttc index and remove unused code. (Closed)

Created:
6 years, 4 months ago by bungeman-skia
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Correct Android FontMgr use of ttc index and remove unused code. Committed: https://skia.googlesource.com/skia/+/07cfb20a0b9a14b8daeb56fcf21d810e91387fd1

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M src/ports/SkFontMgr_android.cpp View 1 4 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bungeman-skia
This addresses several issues discovered while working on https://codereview.chromium.org/427293003/ but which aren't actually directly related.
6 years, 4 months ago (2014-07-30 17:16:08 UTC) #1
djsollen
lgtm https://codereview.chromium.org/433503003/diff/1/src/ports/SkFontMgr_android.cpp File src/ports/SkFontMgr_android.cpp (right): https://codereview.chromium.org/433503003/diff/1/src/ports/SkFontMgr_android.cpp#newcode137 src/ports/SkFontMgr_android.cpp:137: int ttcIndex = family->fFontFiles[i].fIndex; const int
6 years, 4 months ago (2014-07-30 17:32:46 UTC) #2
bungeman-skia
https://codereview.chromium.org/433503003/diff/1/src/ports/SkFontMgr_android.cpp File src/ports/SkFontMgr_android.cpp (right): https://codereview.chromium.org/433503003/diff/1/src/ports/SkFontMgr_android.cpp#newcode137 src/ports/SkFontMgr_android.cpp:137: int ttcIndex = family->fFontFiles[i].fIndex; On 2014/07/30 17:32:46, djsollen wrote: ...
6 years, 4 months ago (2014-07-30 17:52:21 UTC) #3
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 4 months ago (2014-07-30 17:53:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/433503003/20001
6 years, 4 months ago (2014-07-30 17:53:51 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-30 18:05:26 UTC) #6
Message was sent while issue was closed.
Change committed as 07cfb20a0b9a14b8daeb56fcf21d810e91387fd1

Powered by Google App Engine
This is Rietveld 408576698