Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 433493002: Hide some SyzyASan specific code behind an '#if defined(COMPILER_MSVC)'. (Closed)

Created:
6 years, 4 months ago by Sébastien Marchand
Modified:
6 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Hide some SyzyASan specific code behind an '#if defined(COMPILER_MSVC)'. This is necessary for the code in base/debug/... because it gets included by base_nacl which is compiled with g++ which doesn't support SyzyASan. R=thakis@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286699

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M base/debug/asan_invalid_access.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/debug/asan_invalid_access.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Sébastien Marchand
PTALé
6 years, 4 months ago (2014-07-30 15:58:42 UTC) #1
Nico
lgtm! https://codereview.chromium.org/433493002/diff/1/base/debug/asan_invalid_access.cc File base/debug/asan_invalid_access.cc (right): https://codereview.chromium.org/433493002/diff/1/base/debug/asan_invalid_access.cc#newcode102 base/debug/asan_invalid_access.cc:102: #endif // SYZYASAN nit: update?
6 years, 4 months ago (2014-07-30 16:50:39 UTC) #2
Sébastien Marchand
The CQ bit was checked by sebmarchand@chromium.org
6 years, 4 months ago (2014-07-30 16:56:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/433493002/20001
6 years, 4 months ago (2014-07-30 16:58:09 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium.mac ...
6 years, 4 months ago (2014-07-30 18:50:50 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-30 21:03:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/1563)
6 years, 4 months ago (2014-07-30 21:03:55 UTC) #7
Sébastien Marchand
The CQ bit was checked by sebmarchand@chromium.org
6 years, 4 months ago (2014-07-30 21:05:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sebmarchand@chromium.org/433493002/20001
6 years, 4 months ago (2014-07-30 21:06:39 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 03:12:07 UTC) #10
Message was sent while issue was closed.
Change committed as 286699

Powered by Google App Engine
This is Rietveld 408576698