Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 433463002: Avoid calling memchr with a zero range as this is undefined behavior. (Closed)

Created:
6 years, 4 months ago by rmcilroy
Modified:
6 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Avoid calling memchr with a zero range as this is undefined behavior. Calling memchr with a zero range is not explicitly specified to return NULL, and on Android arm64 it returns an undefined value instead. This CL ensures we don't call it with a zero range. BUG=395678 LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M src/runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/string-search.h View 4 chunks +17 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rmcilroy
Yang, could you please take a look. Thanks.
6 years, 4 months ago (2014-07-30 14:25:46 UTC) #1
Yang
On 2014/07/30 14:25:46, rmcilroy wrote: > Yang, could you please take a look. Thanks. LGTM!
6 years, 4 months ago (2014-07-30 14:28:53 UTC) #2
Yang
The CQ bit was checked by yangguo@chromium.org
6 years, 4 months ago (2014-07-31 07:53:43 UTC) #3
Yang
The CQ bit was unchecked by yangguo@chromium.org
6 years, 4 months ago (2014-07-31 07:53:46 UTC) #4
Yang
The CQ bit was checked by yangguo@chromium.org
6 years, 4 months ago (2014-07-31 07:53:48 UTC) #5
Yang
The CQ bit was unchecked by yangguo@chromium.org
6 years, 4 months ago (2014-07-31 07:53:55 UTC) #6
rmcilroy
On 2014/07/31 07:53:55, Yang wrote: > The CQ bit was unchecked by mailto:yangguo@chromium.org The Android ...
6 years, 4 months ago (2014-07-31 11:24:53 UTC) #7
rmcilroy
6 years, 4 months ago (2014-07-31 16:30:48 UTC) #8
On 2014/07/31 11:24:53, rmcilroy wrote:
> On 2014/07/31 07:53:55, Yang wrote:
> > The CQ bit was unchecked by mailto:yangguo@chromium.org
> 
> The Android team fixed the issue, however should I still land this to be safe?

> Can I land it now while the tree is still throttled, it should be safe?

Dropping this since it has been fixed by Android.

Powered by Google App Engine
This is Rietveld 408576698