Issue 433423003: Animations: Make perf tests for web animations animate properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 433423003: Animations: Make perf tests for web animations animate properly. (Closed)

Created:
6 years, 4 months ago by dshwang

Modified:
6 years, 4 months ago

Reviewers:
dstockwell, shans, rjwright

CC:
dstockwell, darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Animations: Make perf tests for web animations animate properly. Web Animations uses ms for duration, while legacy keyframe animations uses sec for duration. Currently, the given perf tests use sec, so animations are weird. BUG=309981 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180150

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -9 lines)			Patch
	M	PerformanceTests/Animation/api-balls-keyframe-animations.html	View		3 chunks	+2 lines, -5 lines	0 comments	Download
	M	PerformanceTests/Animation/api-set-current-time-balls-keyframe-animations.html	View		3 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/433423003/1

6 years, 4 months ago (2014-08-13 06:36:14 UTC) #5

Message was sent while issue was closed.

Change committed as 180150

Expand Messages | Collapse Messages