Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 433423002: [DevTools] Remove old screencast events code after switch to touch emulator. (Closed)

Created:
6 years, 4 months ago by dgozman
Modified:
6 years, 4 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove old screencast events code after switch to touch emulator. BUG=384522 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287517

Patch Set 1 #

Total comments: 2

Patch Set 2 : Better error handling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -158 lines) Patch
M content/browser/devtools/renderer_overrides_handler.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/devtools/renderer_overrides_handler.cc View 1 7 chunks +42 lines, -152 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dgozman
Take a look please.
6 years, 4 months ago (2014-08-04 09:41:33 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/433423002/diff/1/content/browser/devtools/renderer_overrides_handler.cc File content/browser/devtools/renderer_overrides_handler.cc (right): https://codereview.chromium.org/433423002/diff/1/content/browser/devtools/renderer_overrides_handler.cc#newcode858 content/browser/devtools/renderer_overrides_handler.cc:858: return NULL; return error responce instead.
6 years, 4 months ago (2014-08-04 12:16:22 UTC) #2
dgozman
https://codereview.chromium.org/433423002/diff/1/content/browser/devtools/renderer_overrides_handler.cc File content/browser/devtools/renderer_overrides_handler.cc (right): https://codereview.chromium.org/433423002/diff/1/content/browser/devtools/renderer_overrides_handler.cc#newcode858 content/browser/devtools/renderer_overrides_handler.cc:858: return NULL; On 2014/08/04 12:16:22, pfeldman wrote: > return ...
6 years, 4 months ago (2014-08-05 08:21:01 UTC) #3
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 4 months ago (2014-08-05 08:21:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/433423002/20001
6 years, 4 months ago (2014-08-05 08:24:15 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 11:45:10 UTC) #6
Message was sent while issue was closed. 
Change committed as 287517

Powered by Google App Engine
This is Rietveld 408576698