src/v8natives.js - Issue 433413002: `1..isPrototypeOf.call(null)` should return false, not throw TypeError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8natives.js

Issue 433413002: `1..isPrototypeOf.call(null)` should return false, not throw TypeError. (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Patch Set 5 Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/v8natives.js

diff --git a/src/v8natives.js b/src/v8natives.js

index 00d8a88d7342222a04357665c0b4ae9f11c0501b..dd00c8a5507562ad5a644766efb0f65d74944dd9 100644

--- a/src/v8natives.js

+++ b/src/v8natives.js

@@ -251,8 +251,8 @@ function ObjectHasOwnProperty(V) {

// ECMA-262 - 15.2.4.6

function ObjectIsPrototypeOf(V) {

- CHECK_OBJECT_COERCIBLE(this, "Object.prototype.isPrototypeOf");

if (!IS_SPEC_OBJECT(V)) return false;

+ CHECK_OBJECT_COERCIBLE(this, "Object.prototype.isPrototypeOf");

return %IsInPrototypeChain(this, V);

}

« no previous file with comments | « no previous file | test/mjsunit/function-call.js » ('j') | no next file with comments »