Cast: cast_simulator to print more info

Cast: cast_simulator to print more info

Print more information in cast_simulator:
1. Total video frames.
2. Dropped video frames.
3. Late video frames.
4. Avg. target bitrate.
5. Avg. encoded bitrate.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287733

[Alpha Left Google, 2014-08-04 22:30:42]

Ping for review.

[hubbe, 2014-08-04 22:37:25]

https://codereview.chromium.org/433363002/diff/1/media/cast/test/simulator.cc
File media/cast/test/simulator.cc (right):

https://codereview.chromium.org/433363002/diff/1/media/cast/test/simulator.cc...
media/cast/test/simulator.cc:148: void
AppendLog(media::cast::proto::LogMetadata* metadata,
Document with comment?

https://codereview.chromium.org/433363002/diff/1/media/cast/test/simulator.cc...
media/cast/test/simulator.cc:338: media::cast::proto::LogMetadata
audio_metadata, video_metadata;
This is a giant function, but each block above has a comment at least.
This part of the code does not, please fix.

[Alpha Left Google, 2014-08-04 22:44:09]

https://codereview.chromium.org/433363002/diff/1/media/cast/test/simulator.cc
File media/cast/test/simulator.cc (right):

https://codereview.chromium.org/433363002/diff/1/media/cast/test/simulator.cc...
media/cast/test/simulator.cc:148: void
AppendLog(media::cast::proto::LogMetadata* metadata,
On 2014/08/04 22:37:24, hubbe wrote:
> Document with comment?

Done.

https://codereview.chromium.org/433363002/diff/1/media/cast/test/simulator.cc...
media/cast/test/simulator.cc:338: media::cast::proto::LogMetadata
audio_metadata, video_metadata;
On 2014/08/04 22:37:24, hubbe wrote:
> This is a giant function, but each block above has a comment at least.
> This part of the code does not, please fix.

Done.

[hubbe, 2014-08-05 17:46:59]

LGTM

https://codereview.chromium.org/433363002/diff/20001/media/cast/test/simulato...
File media/cast/test/simulator.cc (right):

https://codereview.chromium.org/433363002/diff/20001/media/cast/test/simulato...
media/cast/test/simulator.cc:341: media::cast::proto::LogMetadata
audio_metadata, video_metadata;
Optional: Put metadata, frame_events and packet_events in a struct pass the
struct to AppendLogToFile, that would clean the code up a little bit.

[Alpha Left Google, 2014-08-06 01:51:58]

https://codereview.chromium.org/433363002/diff/20001/media/cast/test/simulato...
File media/cast/test/simulator.cc (right):

https://codereview.chromium.org/433363002/diff/20001/media/cast/test/simulato...
media/cast/test/simulator.cc:341: media::cast::proto::LogMetadata
audio_metadata, video_metadata;
On 2014/08/05 17:46:59, hubbe wrote:
> Optional: Put metadata, frame_events and packet_events in a struct pass the
> struct to AppendLogToFile, that would clean the code up a little bit.

I'm not sure how using a struct will make it cleaner.. The resultant number of
code will probably be the same.

[Alpha Left Google, 2014-08-06 01:52:06]

The CQ bit was checked by hclam@chromium.org

[commit-bot: I haz the power, 2014-08-06 01:54:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hclam@chromium.org/433363002/40001

[commit-bot: I haz the power, 2014-08-06 07:56:07]

Change committed as 287733