Issue 43333003: Move movq(Register, ExternalReference) into X64 MacroAssembler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43333003: Move movq(Register, ExternalReference) into X64 MacroAssembler (Closed)

Created:
7 years, 2 months ago by haitao.feng

Modified:
7 years, 1 month ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Move movq(Register, ExternalReference) into X64 MacroAssembler R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17537

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -41 lines)			Patch
M	src/x64/assembler-x64.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/x64/builtins-x64.cc	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	5 chunks	+7 lines, -7 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/x64/debug-x64.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	8 chunks	+10 lines, -10 lines	0 comments	Download
M	src/x64/regexp-macro-assembler-x64.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

haitao.feng

We could abstract the difference of X64 and X32 in the macro assembler instruction. PTAL.

7 years, 2 months ago (2013-10-25 06:31:20 UTC) #1

haitao.feng

7 years, 1 month ago (2013-11-07 02:10:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r17537 (presubmit successful).