Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 433293002: When normalize coordinate, return instead of assert() when divide by 0 (Closed)

Created:
6 years, 4 months ago by Bo Xu
Modified:
5 years, 9 months ago
Reviewers:
Tom Sepez, jun_fang
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

When normalize coordinate, return instead of assert() when divide by 0 BUG=382988 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/fda0d42

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M core/include/fxcrt/fx_coordinates.h View 1 chunk +3 lines, -1 line 2 comments Download

Messages

Total messages: 6 (0 generated)
Bo Xu
6 years, 4 months ago (2014-08-02 22:20:17 UTC) #1
Bo Xu
6 years, 4 months ago (2014-08-04 14:00:43 UTC) #2
Tom Sepez
https://codereview.chromium.org/433293002/diff/1/core/include/fxcrt/fx_coordinates.h File core/include/fxcrt/fx_coordinates.h (right): https://codereview.chromium.org/433293002/diff/1/core/include/fxcrt/fx_coordinates.h#newcode159 core/include/fxcrt/fx_coordinates.h:159: if (fLen < 0.0001f) { Isn't .0001f a kinda ...
6 years, 4 months ago (2014-08-04 17:09:38 UTC) #3
Bo Xu
https://codereview.chromium.org/433293002/diff/1/core/include/fxcrt/fx_coordinates.h File core/include/fxcrt/fx_coordinates.h (right): https://codereview.chromium.org/433293002/diff/1/core/include/fxcrt/fx_coordinates.h#newcode159 core/include/fxcrt/fx_coordinates.h:159: if (fLen < 0.0001f) { On 2014/08/04 17:09:38, Tom ...
6 years, 4 months ago (2014-08-04 18:48:09 UTC) #4
Tom Sepez
OK, LGTM then.
6 years, 4 months ago (2014-08-05 17:21:17 UTC) #5
Bo Xu
6 years, 4 months ago (2014-08-08 02:01:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as fda0d42 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698