Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: components/copresence/handlers/directive_handler.h

Issue 433283002: Adding the Copresence RpcHandler and HttpPost helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@directive-handler
Patch Set: Rebasing off the correct CL Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/copresence/handlers/directive_handler.h
diff --git a/components/copresence/handlers/directive_handler.h b/components/copresence/handlers/directive_handler.h
index 8a415f1dbb77cda9b70dfce35cd6ad2550d1e822..994be3c1d960c87bb35a7e01c8401ebbafa150df 100644
--- a/components/copresence/handlers/directive_handler.h
+++ b/components/copresence/handlers/directive_handler.h
@@ -1,9 +1,9 @@
// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
+// Use of this source code is governed by a BSD-style license
+// that can be found in the LICENSE file.
-#ifndef COMPONENTS_COPRESENCE_HANDLERS_DIRECTIVE_HANDLER_
-#define COMPONENTS_COPRESENCE_HANDLERS_DIRECTIVE_HANDLER_
+#ifndef COMPONENTS_COPRESENCE_HANDLERS_DIRECTIVE_HANDLER_H_
+#define COMPONENTS_COPRESENCE_HANDLERS_DIRECTIVE_HANDLER_H_
#include <string>
@@ -18,19 +18,23 @@ namespace copresence {
class AudioDirectiveHandler;
class Directive;
-// The directive handler manages transmit and receive directives given to it
-// by the client.
+// The directive handler manages transmit and receive directives
+// given to it by the client.
Daniel Erat 2014/08/06 00:44:46 is your editor wrapping comments at some width les
Charlie 2014/08/06 19:32:18 See previous response. On 2014/08/06 00:44:46, Da
class DirectiveHandler {
public:
DirectiveHandler(const AudioRecorder::DecodeSamplesCallback& decode_cb,
const AudioDirectiveList::EncodeTokenCallback& encode_cb);
- ~DirectiveHandler();
+ virtual ~DirectiveHandler();
// Adds a directive to handle.
- void AddDirective(const copresence::Directive& directive);
+ virtual void AddDirective(const copresence::Directive& directive);
// Removes any directives associated with the given operation id.
void RemoveDirectives(const std::string& op_id);
+ protected:
+ // Empty constructor for testing.
+ DirectiveHandler();
+
private:
scoped_ptr<AudioDirectiveHandler> audio_handler_;
@@ -39,4 +43,4 @@ class DirectiveHandler {
} // namespace copresence
-#endif // COMPONENTS_COPRESENCE_HANDLERS_DIRECTIVE_HANDLER_
+#endif // COMPONENTS_COPRESENCE_HANDLERS_DIRECTIVE_HANDLER_H_

Powered by Google App Engine
This is Rietveld 408576698