components/copresence/public/copresence_client.h - Issue 433283002: Adding the Copresence RpcHandler and HttpPost helper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/copresence/public/copresence_client.h

Issue 433283002: Adding the Copresence RpcHandler and HttpPost helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@directive-handler

Patch Set: More WeakPtr fixes Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/copresence/copresence_client.cc ('K') | « components/copresence/proto/rpcs.proto ('k') | components/copresence/public/copresence_client_delegate.h » ('j') | components/copresence/rpc/http_post.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/copresence/public/copresence_client.h

diff --git a/components/copresence/public/copresence_client.h b/components/copresence/public/copresence_client.h

index 40b8bf97bfe4720e83416fae7eabd5e89574a568..c671fc3d427a8a8782434a9e14f1852107794b3c 100644

--- a/components/copresence/public/copresence_client.h

+++ b/components/copresence/public/copresence_client.h

@@ -11,7 +11,6 @@

#include "base/callback.h"

#include "base/macros.h"

#include "base/memory/scoped_ptr.h"

-#include "base/memory/weak_ptr.h"

#include "components/copresence/proto/rpcs.pb.h"

#include "components/copresence/public/copresence_client_delegate.h"

@@ -39,7 +38,7 @@ struct PendingRequest {

// functionality. This class handles all the initialization and delegation of

// copresence tasks. Any user of copresence only needs to interact with this

// client.

-class CopresenceClient : public base::SupportsWeakPtr<CopresenceClient> {

+class CopresenceClient {

public:

// The delegate must outlive us.

explicit CopresenceClient(CopresenceClientDelegate* delegate);