Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: components/copresence/rpc/http_post.h

Issue 433283002: Adding the Copresence RpcHandler and HttpPost helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@directive-handler
Patch Set: Rebasing off the correct CL Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license
3 // that can be found in the LICENSE file.
4
5 #ifndef COMPONENTS_COPRESENCE_RPC_HTTP_POST_H_
6 #define COMPONENTS_COPRESENCE_RPC_HTTP_POST_H_
7
8 #include <string>
9
10 #include "base/callback.h"
11 #include "base/macros.h"
12 #include "base/memory/scoped_ptr.h"
13 #include "base/memory/weak_ptr.h"
14 #include "net/url_request/url_fetcher_delegate.h"
15
16 namespace google {
17 namespace protobuf {
18 class MessageLite;
19 }
20 }
21
22 namespace net {
23 class URLRequestContextGetter;
24 }
25
26 namespace copresence {
27
28 /**
29 * This class handles all Apiary calls to the Copresence server.
Daniel Erat 2014/08/06 00:44:47 use c++-style comments (//)
Charlie 2014/08/06 19:32:18 Done. Is this in the style guide? I suppose Chromi
30 * It configures the HTTP request appropriately and reports any errors.
31 * Clients should not attempt to delete this class, as it needs to
32 * persist until the HTTP request completes (or times out).
33 *
34 * TODO(ckehoe): Add retry logic.
35 * TODO(ckehoe): Template this class to parse the proto received.
36 */
37 class HttpPost : public net::URLFetcherDelegate,
38 public base::SupportsWeakPtr<HttpPost> {
39 public:
40 // Callback to receive the HTTP status code and body of the response (if any).
41 typedef base::Callback<void(int, const std::string&)> ResponseCallback;
42
43 // An id for testing url fetching.
44 static const int kUrlFetcherId = 1;
45
46 HttpPost(net::URLRequestContextGetter* url_context_getter,
Daniel Erat 2014/08/06 00:44:47 document whether the ownership of this argument is
Charlie 2014/08/06 19:32:18 Done.
47 const std::string& rpc_name,
48 const scoped_ptr<google::protobuf::MessageLite> request_proto,
Daniel Erat 2014/08/06 00:44:47 const reference instead of const scoped_ptr?
Charlie 2014/08/06 19:32:18 Done.
49 const ResponseCallback& response_callback);
50
51 private:
52 // This class deletes itself when the request completes (or times out).
53 virtual ~HttpPost();
54
55 // Overridden from net::URLFetcherDelegate.
56 virtual void OnURLFetchComplete(const net::URLFetcher* source) OVERRIDE;
57
58 ResponseCallback response_callback_;
59 scoped_ptr<net::URLFetcher> url_fetcher_;
60
61 DISALLOW_COPY_AND_ASSIGN(HttpPost);
62 };
63
64 } // namespace copresence
65
66 #endif // COMPONENTS_COPRESENCE_RPC_HTTP_POST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698