Adding the Copresence RpcHandler and HttpPost helper.

components/copresence/handlers/directive_handler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
+// Use of this source code is governed by a BSD-style license
+// that can be found in the LICENSE file.
 
 #include "components/copresence/handlers/directive_handler.h"
 
 #include "base/time/time.h"
 #include "components/copresence/handlers/audio/audio_directive_handler.h"
 #include "components/copresence/proto/data.pb.h"
 
 namespace copresence {
 
 DirectiveHandler::DirectiveHandler(
@@ skipping 14 matching lines @@
   // We currently only support audio.
   DCHECK_EQ(ti.medium(), AUDIO_ULTRASOUND_PASSBAND);
   audio_handler_->AddInstruction(
       ti, base::TimeDelta::FromMilliseconds(directive.ttl_millis()));
 }
 
 void DirectiveHandler::RemoveDirectives(const std::string& /* op_id */) {
   // TODO(rkc): Forward the remove directive call to all the directive handlers.
 }
 
+// Protected
+
+DirectiveHandler::DirectiveHandler() {

[Daniel Erat, 2014/08/06 00:44:46]

this leaves the object in a state where methods will crash (e.g. AddDirective()
appears to depend on audio_handler_ being a valid object). please instead use a
stub implementation for tests.

[Charlie, 2014/08/06 19:32:18]

Not sure I understand - FakeDirectiveHandler is the stub implementation, and it
still needs a constructor to invoke. I moved all the initialization to an
Initialize() method, and added DCHECKs.

On 2014/08/06 00:44:46, Daniel Erat wrote:

+}
+
 }  // namespace copresence