content/public/browser/content_browser_client.h - Issue 433273002: NotificationObjectProxy should own the DesktopNotificationDelegateImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/content_browser_client.h

Issue 433273002: NotificationObjectProxy should own the DesktopNotificationDelegateImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: pass as scoped_ptr Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/browser/content_browser_client.h

diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h

index 1885fe224d56f7333f3b8dcda72a9641ec586747..23ea93765f8faa3b1750b26d06aaad0da2533a23 100644

--- a/content/public/browser/content_browser_client.h

+++ b/content/public/browser/content_browser_client.h

@@ -16,6 +16,7 @@

#include "base/memory/scoped_vector.h"

#include "base/values.h"

#include "content/public/browser/certificate_request_result_type.h"

+#include "content/public/browser/desktop_notification_delegate.h"

#include "content/public/common/content_client.h"

#include "content/public/common/resource_type.h"

#include "content/public/common/socket_permission_request.h"

@@ -437,7 +438,7 @@ class CONTENT_EXPORT ContentBrowserClient {

virtual void ShowDesktopNotification(

const ShowDesktopNotificationHostMsgParams& params,

RenderFrameHost* render_frame_host,

- DesktopNotificationDelegate* delegate,

+ scoped_ptr<DesktopNotificationDelegate> delegate,

base::Closure* cancel_callback) {}

// The renderer is requesting permission to use Geolocation. When the answer

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | no next file » | no next file with comments »