Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1623)

Unified Diff: chrome/browser/notifications/notification_object_proxy.cc

Issue 433273002: NotificationObjectProxy should own the DesktopNotificationDelegateImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: pass as scoped_ptr Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_object_proxy.cc
diff --git a/chrome/browser/notifications/notification_object_proxy.cc b/chrome/browser/notifications/notification_object_proxy.cc
index af4524b94ba8f6331c5a7cec20a4c09226868dc9..1025c59791941ea7803bc4410a6460ce9e2c6db4 100644
--- a/chrome/browser/notifications/notification_object_proxy.cc
+++ b/chrome/browser/notifications/notification_object_proxy.cc
@@ -13,14 +13,16 @@
NotificationObjectProxy::NotificationObjectProxy(
content::RenderFrameHost* render_frame_host,
- content::DesktopNotificationDelegate* delegate)
+ scoped_ptr<content::DesktopNotificationDelegate> delegate)
: render_process_id_(render_frame_host->GetProcess()->GetID()),
render_frame_id_(render_frame_host->GetRoutingID()),
- delegate_(delegate),
+ delegate_(delegate.Pass()),
displayed_(false),
id_(base::GenerateGUID()) {
}
+NotificationObjectProxy::~NotificationObjectProxy() {}
+
void NotificationObjectProxy::Display() {
// This method is called each time the notification is shown to the user
// but we only want to fire the event the first time.
« no previous file with comments | « chrome/browser/notifications/notification_object_proxy.h ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698