chrome/browser/notifications/notification_browsertest.cc - Issue 433273002: NotificationObjectProxy should own the DesktopNotificationDelegateImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_browsertest.cc

Issue 433273002: NotificationObjectProxy should own the DesktopNotificationDelegateImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: pass as scoped_ptr Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/desktop_notification_service.cc ('k') | chrome/browser/notifications/notification_object_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_browsertest.cc

diff --git a/chrome/browser/notifications/notification_browsertest.cc b/chrome/browser/notifications/notification_browsertest.cc

index 5f4462d3158adfbd71cbc2e38c338131e3278200..e58df65cffd7a3e03f21666cec8aa2554c042010 100644

--- a/chrome/browser/notifications/notification_browsertest.cc

+++ b/chrome/browser/notifications/notification_browsertest.cc

@@ -743,14 +743,7 @@ IN_PROC_BROWSER_TEST_F(NotificationsTest,

ASSERT_EQ(1, GetNotificationCount());

}

-// See http://crbug.com/366539

-#if defined(OS_LINUX)

-#define MAYBE_TestNotificationReplacement DISABLED_TestNotificationReplacement

-#else

-#define MAYBE_TestNotificationReplacement TestNotificationReplacement

-#endif

-IN_PROC_BROWSER_TEST_F(NotificationsTest, MAYBE_TestNotificationReplacement) {

+IN_PROC_BROWSER_TEST_F(NotificationsTest, TestNotificationReplacement) {

ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());

// Test that we can replace a notification using the replaceId.