android_webview/browser/aw_content_browser_client.cc - Issue 433273002: NotificationObjectProxy should own the DesktopNotificationDelegateImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 433273002: NotificationObjectProxy should own the DesktopNotificationDelegateImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: pass as scoped_ptr Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/browser/aw_content_browser_client.cc

diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc

index 000a09b411f8ea2fd0a787fd5696990eba6dc3a4..c189a3817c1a8265c828ef09799e8f2abe79cb63 100644

--- a/android_webview/browser/aw_content_browser_client.cc

+++ b/android_webview/browser/aw_content_browser_client.cc

@@ -406,7 +406,7 @@ blink::WebNotificationPermission

void AwContentBrowserClient::ShowDesktopNotification(

const content::ShowDesktopNotificationHostMsgParams& params,

content::RenderFrameHost* render_frame_host,

- content::DesktopNotificationDelegate* delegate,

+ scoped_ptr<content::DesktopNotificationDelegate> delegate,

base::Closure* cancel_callback) {

NOTREACHED() << "Android WebView does not support desktop notifications.";

}

« no previous file with comments | « android_webview/browser/aw_content_browser_client.h ('k') | chrome/browser/chrome_content_browser_client.h » ('j') | no next file with comments »