content/browser/frame_host/render_frame_host_impl.cc - Issue 433273002: NotificationObjectProxy should own the DesktopNotificationDelegateImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 433273002: NotificationObjectProxy should own the DesktopNotificationDelegateImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index eb459ede4b43bf2b77a7e3ef1ca8367f4166d185..af172a295ccc2a6e41415aa264269d8dbb940ec4 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -90,7 +90,6 @@ class DesktopNotificationDelegateImpl : public DesktopNotificationDelegate {

rfh->Send(new DesktopNotificationMsg_PostError(

rfh->GetRoutingID(), notification_id_));

- delete this;

}

virtual void NotificationClosed(bool by_user) OVERRIDE {

@@ -103,7 +102,6 @@ class DesktopNotificationDelegateImpl : public DesktopNotificationDelegate {

rfh->GetRoutingID(), notification_id_, by_user));

static_cast<RenderFrameHostImpl*>(rfh)->NotificationClosed(

notification_id_);

- delete this;

}

virtual void NotificationClick() OVERRIDE {

« chrome/browser/notifications/notification_object_proxy.h ('K') | « chrome/browser/notifications/notification_object_proxy.cc ('k') | no next file » | no next file with comments »