Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1122)

Issue 433213003: Enable password generation by default. (Closed)

Created:
6 years, 4 months ago by Ilya Sherman
Modified:
6 years, 4 months ago
Reviewers:
Garrett Casto
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, mkwst+watchlist_chromium.org
Project:
chromium
Visibility:
Public.

Description

Enable password generation by default. Due to the current experiment setup, this feature will still only be used by a fraction of canary/dev users, but the trybots should now run with this feature enabled. BUG=114092, 295787 R=gcasto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287188

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/autofill/core/common/password_generation_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Ilya Sherman
6 years, 4 months ago (2014-08-01 23:47:03 UTC) #1
Garrett Casto
lgtm
6 years, 4 months ago (2014-08-01 23:53:21 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 4 months ago (2014-08-01 23:53:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/433213003/1
6 years, 4 months ago (2014-08-01 23:55:39 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 08:06:14 UTC) #5
Message was sent while issue was closed.
Change committed as 287188

Powered by Google App Engine
This is Rietveld 408576698