Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 433203002: leveldatabase.gyp cleanup (Closed)

Created:
6 years, 4 months ago by Mostyn Bramley-Moore
Modified:
6 years, 4 months ago
Reviewers:
jsbell, cmumford
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

leveldatabase.gyp cleanup Followup for some style issues identified in https://codereview.chromium.org/432083003/ * move windows source files into the main list (and filter *_win.{cc,h} on non-windows platforms for all targets) * remove exclusions of files that don't exist (*_android.cc & *_portable.cc) * exclude header files corresponding to excluded .cc files BUG=381456 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287374

Patch Set 1 : move windows source files into the main list #

Patch Set 2 : there are no _android.* or _portable.* files #

Patch Set 3 : exclude header files too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M third_party/leveldatabase/leveldatabase.gyp View 1 2 4 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mostyn Bramley-Moore
@jsbell: here's some of the cleanup you requested.
6 years, 4 months ago (2014-08-01 22:53:55 UTC) #1
jsbell
lgtm but I'd like cmumford to take a look, as he's done more gyp editing ...
6 years, 4 months ago (2014-08-01 23:36:05 UTC) #2
cmumford
lgtm
6 years, 4 months ago (2014-08-04 15:20:38 UTC) #3
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 4 months ago (2014-08-04 16:53:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/433203002/40001
6 years, 4 months ago (2014-08-04 16:55:03 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 18:24:37 UTC) #6
Message was sent while issue was closed.
Change committed as 287374

Powered by Google App Engine
This is Rietveld 408576698