Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 433193002: [NaCl SDK] nacl_io: Remove unneeded glibc syscall entry points. (Closed)

Created:
6 years, 4 months ago by Sam Clegg
Modified:
6 years, 4 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] nacl_io: Remove unneeded glibc syscall entry points. These can now be intercepted within glibc so there is no need to implement them directly. mkdir/mkdir were also be intercepted at this level under newlib unnecessarily. It seems that truncate.c is still needed but I've got a fix for that in glibc: https://codereview.chromium.org/439003002/ BUG= https://code.google.com/p/nativeclient/issues/detail?id=3709 R=binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287745

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -241 lines) Patch
M native_client_sdk/src/examples/tutorial/testing/example.dsc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/gtest/library.dsc View 1 1 chunk +0 lines, -1 line 1 comment Download
D native_client_sdk/src/libraries/gtest/nacl_gtest_dummy_sys.cc View 1 1 chunk +0 lines, -40 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_wrap_glibc.cc View 1 2 7 chunks +68 lines, -22 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/kernel_wrap_newlib.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/library.dsc View 1 4 chunks +0 lines, -10 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/access.c View 1 chunk +2 lines, -3 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/chdir.c View 1 chunk +0 lines, -15 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/fchdir.c View 1 chunk +0 lines, -15 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/fchmod.c View 1 chunk +0 lines, -15 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/fdatasync.c View 1 chunk +0 lines, -15 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/fsync.c View 1 chunk +0 lines, -15 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/getcwd.c View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/lstat.c View 1 chunk +0 lines, -18 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/mkdir.c View 1 1 chunk +0 lines, -16 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/readlink.c View 1 chunk +0 lines, -15 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/rmdir.c View 1 1 chunk +0 lines, -10 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/syscalls/unlink.c View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/utimes.c View 1 chunk +0 lines, -15 lines 0 comments Download
M native_client_sdk/src/tests/nacl_io_socket_test/example.dsc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/example.dsc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/kernel_wrap_test.cc View 1 2 5 chunks +22 lines, -10 lines 0 comments Download
M native_client_sdk/src/tests/sdk_util_test/example.dsc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Sam Clegg
6 years, 4 months ago (2014-08-01 23:09:58 UTC) #1
Sam Clegg
ptal
6 years, 4 months ago (2014-08-05 17:31:00 UTC) #2
binji
lgtm https://codereview.chromium.org/433193002/diff/180001/native_client_sdk/src/libraries/gtest/library.dsc File native_client_sdk/src/libraries/gtest/library.dsc (left): https://codereview.chromium.org/433193002/diff/180001/native_client_sdk/src/libraries/gtest/library.dsc#oldcode22 native_client_sdk/src/libraries/gtest/library.dsc:22: 'nacl_gtest_dummy_sys.cc', OK, but this means we can't use ...
6 years, 4 months ago (2014-08-05 18:53:10 UTC) #3
Sam Clegg
On 2014/08/05 18:53:10, binji wrote: > lgtm > > https://codereview.chromium.org/433193002/diff/180001/native_client_sdk/src/libraries/gtest/library.dsc > File native_client_sdk/src/libraries/gtest/library.dsc (left): > ...
6 years, 4 months ago (2014-08-06 09:39:13 UTC) #4
Sam Clegg
6 years, 4 months ago (2014-08-06 09:41:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #10 manually as 287745 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698