Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 433183002: Update clang warnings after r287092. (Closed)

Created:
6 years, 4 months ago by Nico
Modified:
6 years, 4 months ago
Reviewers:
hans
CC:
chromium-reviews, jungshik at Google
Base URL:
http://src.chromium.org/chrome/trunk/deps/third_party/icu52/
Visibility:
Public.

Description

Update clang warnings after r287092. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=287122

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -44 lines) Patch
M icu.gyp View 4 chunks +28 lines, -44 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
6 years, 4 months ago (2014-08-01 22:15:23 UTC) #1
hans
lgtm
6 years, 4 months ago (2014-08-01 23:31:48 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 4 months ago (2014-08-01 23:52:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/433183002/1
6 years, 4 months ago (2014-08-01 23:52:21 UTC) #4
Nico
jshin: Do I need to do anything to make sure this doesn't get lost after ...
6 years, 4 months ago (2014-08-01 23:52:36 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 23:52:58 UTC) #6
Message was sent while issue was closed. 
Change committed as 287122

Powered by Google App Engine
This is Rietveld 408576698