Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: chromeos/ime/extension_ime_util.cc

Issue 433163005: Refactoring for InputMethodEngine and InputMethodEventRouter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/ime/extension_ime_util.cc
diff --git a/chromeos/ime/extension_ime_util.cc b/chromeos/ime/extension_ime_util.cc
index 474622df28773e9271c9baf3501457eceb6b5ca1..5d69467b115db6564fdb73b53e7fe3bdb982bea6 100644
--- a/chromeos/ime/extension_ime_util.cc
+++ b/chromeos/ime/extension_ime_util.cc
@@ -54,6 +54,16 @@ std::string GetExtensionIDFromInputMethodID(
return "";
}
+std::string GetEngineIDByInputMethodID(const std::string& input_method_id) {
+ if (IsComponentExtensionIME(input_method_id))
+ return input_method_id.substr(kComponentExtensionIMEPrefixLength +
+ kExtensionIdLength);
+ if (IsExtensionIME(input_method_id))
+ return input_method_id.substr(kExtensionIMEPrefixLength +
+ kExtensionIdLength);
+ return input_method_id;
+}
+
std::string GetInputMethodIDByEngineID(const std::string& engine_id) {
if (StartsWithASCII(engine_id, kComponentExtensionIMEPrefix, true) ||
StartsWithASCII(engine_id, kExtensionIMEPrefix, true)) {
@@ -111,11 +121,8 @@ bool IsKeyboardLayoutExtension(const std::string& input_method_id) {
}
std::string MaybeGetLegacyXkbId(const std::string& input_method_id) {
- if (IsKeyboardLayoutExtension(input_method_id)) {
- size_t pos = input_method_id.find("xkb:");
- if (pos != std::string::npos)
- return input_method_id.substr(pos);
- }
+ if (IsKeyboardLayoutExtension(input_method_id))
+ return GetEngineIDByInputMethodID(input_method_id);
return input_method_id;
}

Powered by Google App Engine
This is Rietveld 408576698