Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2525)

Unified Diff: chrome/browser/chromeos/input_method/mock_input_method_engine.h

Issue 433163005: Refactoring for InputMethodEngine and InputMethodEventRouter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: error tolerance for missing background page for key events. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/mock_input_method_engine.h
diff --git a/chrome/browser/chromeos/input_method/mock_input_method_engine.h b/chrome/browser/chromeos/input_method/mock_input_method_engine.h
index c22ac5d56d20e1c6a4de67da6e769f9b02804673..b6ddaaf7983ed59175524121afff199bf6d5dbe1 100644
--- a/chrome/browser/chromeos/input_method/mock_input_method_engine.h
+++ b/chrome/browser/chromeos/input_method/mock_input_method_engine.h
@@ -32,14 +32,11 @@ struct KeyEventHandle;
class MockInputMethodEngine : public InputMethodEngineInterface {
public:
- explicit MockInputMethodEngine(
- const input_method::InputMethodDescriptor& descriptor);
+ explicit MockInputMethodEngine();
virtual ~MockInputMethodEngine();
// InputMethodEngineInterface overrides.
- virtual const input_method::InputMethodDescriptor& GetDescriptor()
- const OVERRIDE;
- virtual void NotifyImeReady() OVERRIDE;
+ virtual const std::string& GetActiveComponentId() const OVERRIDE;
virtual bool SetComposition(int context_id,
const char* text,
int selection_start,
@@ -75,7 +72,7 @@ class MockInputMethodEngine : public InputMethodEngineInterface {
virtual void FocusIn(
const IMEEngineHandlerInterface::InputContext& input_context) OVERRIDE;
virtual void FocusOut() OVERRIDE;
- virtual void Enable() OVERRIDE;
+ virtual void Enable(const std::string& component_id) OVERRIDE;
virtual void Disable() OVERRIDE;
virtual void PropertyActivate(const std::string& property_name) OVERRIDE;
virtual void Reset() OVERRIDE;
@@ -91,8 +88,7 @@ class MockInputMethodEngine : public InputMethodEngineInterface {
}
private:
- // Descriptor of this input method.
- input_method::InputMethodDescriptor descriptor_;
+ std::string active_component_id_;
// The current candidate window property.
CandidateWindowProperty candidate_window_property_;

Powered by Google App Engine
This is Rietveld 408576698