Remove references to __system_property_get from Skia

Remove references to __system_property_get from Skia

BUG=392201
Committed: https://skia.googlesource.com/skia/+/a6c27bc5bd3b213d1e315c0bd9bbdcd75cec6900

[tomhudson, 2014-08-01 20:13:00]

lgtm

[djsollen, 2014-08-01 20:13:41]

https://codereview.chromium.org/433163002/diff/1/src/ports/SkFontConfigParser...
File src/ports/SkFontConfigParser_android.cpp (right):

https://codereview.chromium.org/433163002/diff/1/src/ports/SkFontConfigParser...
src/ports/SkFontConfigParser_android.cpp:250: const int minSize =
strlen(LOCALE_FALLBACK_FONTS_PREFIX) +
it appears that both fallback_fonts-**.xml and vendor_fonts-**.xml were
acceptable variations so we'll need to account for vendor_fonts as well.

[bungeman-skia, 2014-08-01 20:41:25]

https://codereview.chromium.org/433163002/diff/1/src/ports/SkFontConfigInterf...
File src/ports/SkFontConfigInterface_android.cpp (right):

https://codereview.chromium.org/433163002/diff/1/src/ports/SkFontConfigInterf...
src/ports/SkFontConfigInterface_android.cpp:516: FallbackFontList*
fallbackFontList = fLocaleFallbackFontList;
Any reason not to just use fLocaleFallbackFontList directly the whole two times
it is used below?

https://codereview.chromium.org/433163002/diff/1/src/ports/SkFontConfigParser...
File src/ports/SkFontConfigParser_android.cpp (right):

https://codereview.chromium.org/433163002/diff/1/src/ports/SkFontConfigParser...
src/ports/SkFontConfigParser_android.cpp:247: while (dirEntry){
nit: space after ')'

https://codereview.chromium.org/433163002/diff/1/src/ports/SkFontConfigParser...
src/ports/SkFontConfigParser_android.cpp:254: if
(fileName.startsWith(LOCALE_FALLBACK_FONTS_PREFIX) && fileName.size() >=
minSize) {
Do we care to check here if is does end with the SUFFIX?

Should we check that dirEntry is a file (not a directory)?

https://codereview.chromium.org/433163002/diff/1/src/ports/SkFontConfigParser...
src/ports/SkFontConfigParser_android.cpp:256: SkString locale(fileName);
Can this be something like

int localeLen = strlen(LOCALE_FALLBACK_FONTS_PREFIX) -
strlen(LOCALE_FALLBACK_FONTS_SUFFIX);
SkString locale(fileName.c_str() + strlen(LOCALE_FALLBACK_FONTS_PREFIX),
                fileName.size() - localeLen);

It seems a bit clearer and less work than trimming the end and then trimming the
front.

https://codereview.chromium.org/433163002/diff/1/src/ports/SkFontConfigParser...
src/ports/SkFontConfigParser_android.cpp:257: locale.resize(fileName.size() -
strlen(LOCALE_FALLBACK_FONTS_SUFFIX));
Well, I was going to say replace "strlen(CONST_STRING)" with
"SK_ARRAY_COUNT(CONST_STRING) - 1" or something, since it seems odd to be
calling a function like this to create a constant. Apparently all modern
compilers detect this and optimize it away, depending on optimization settings
(gcc starting in 4.2).

[djsollen, 2014-08-04 14:18:26]

https://codereview.chromium.org/433163002/diff/1/src/ports/SkFontConfigInterf...
File src/ports/SkFontConfigInterface_android.cpp (right):

https://codereview.chromium.org/433163002/diff/1/src/ports/SkFontConfigInterf...
src/ports/SkFontConfigInterface_android.cpp:516: FallbackFontList*
fallbackFontList = fLocaleFallbackFontList;
On 2014/08/01 20:41:24, bungeman1 wrote:
> Any reason not to just use fLocaleFallbackFontList directly the whole two
times
> it is used below?

Done.

https://codereview.chromium.org/433163002/diff/1/src/ports/SkFontConfigParser...
File src/ports/SkFontConfigParser_android.cpp (right):

https://codereview.chromium.org/433163002/diff/1/src/ports/SkFontConfigParser...
src/ports/SkFontConfigParser_android.cpp:247: while (dirEntry){
On 2014/08/01 20:41:25, bungeman1 wrote:
> nit: space after ')'

Done.

https://codereview.chromium.org/433163002/diff/1/src/ports/SkFontConfigParser...
src/ports/SkFontConfigParser_android.cpp:254: if
(fileName.startsWith(LOCALE_FALLBACK_FONTS_PREFIX) && fileName.size() >=
minSize) {
On 2014/08/01 20:41:25, bungeman1 wrote:
> Do we care to check here if is does end with the SUFFIX?
> 
> Should we check that dirEntry is a file (not a directory)?

Added suffix checks

https://codereview.chromium.org/433163002/diff/1/src/ports/SkFontConfigParser...
src/ports/SkFontConfigParser_android.cpp:256: SkString locale(fileName);
On 2014/08/01 20:41:24, bungeman1 wrote:
> Can this be something like
> 
> int localeLen = strlen(LOCALE_FALLBACK_FONTS_PREFIX) -
> strlen(LOCALE_FALLBACK_FONTS_SUFFIX);
> SkString locale(fileName.c_str() + strlen(LOCALE_FALLBACK_FONTS_PREFIX),
>                 fileName.size() - localeLen);
> 
> It seems a bit clearer and less work than trimming the end and then trimming
the
> front.

Done.

[bungeman-skia, 2014-08-04 14:52:45]

https://codereview.chromium.org/433163002/diff/20001/src/ports/SkFontConfigIn...
File src/ports/SkFontConfigInterface_android.cpp (right):

https://codereview.chromium.org/433163002/diff/20001/src/ports/SkFontConfigIn...
src/ports/SkFontConfigInterface_android.cpp:514: fLocaleFallbackFontList =
this->findFallbackFontList(locale);
Now that this is cleaner, it sets of my spider sense for threading. Since this
mutates, this could cause havoc if multiple threads were doing this at once. On
the other hand, none of our current users do that, and they don't change this
very much anyway. Also, we're deprecating this file anyway and just keeping it
alive for old webviews. And this doesn't really introduce the problem, just
makes the existing one easier to see. I suppose setting a local gets around the
potential issue of this changing and then doing bad things in the loop below.

[tomhudson, 2014-08-04 15:26:37]

https://codereview.chromium.org/433163002/diff/20001/src/ports/SkFontConfigIn...
File src/ports/SkFontConfigInterface_android.cpp (right):

https://codereview.chromium.org/433163002/diff/20001/src/ports/SkFontConfigIn...
src/ports/SkFontConfigInterface_android.cpp:514: fLocaleFallbackFontList =
this->findFallbackFontList(locale);
So the error case is that two different threads are passed different locales,
and we change fLocaleFallbackFontList from a long list to a shorter one?

[djsollen, 2014-08-06 17:29:51]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2014-08-06 17:30:38]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/djsollen@google.com/433163002/60001

[commit-bot: I haz the power, 2014-08-06 18:02:05]

Change committed as a6c27bc5bd3b213d1e315c0bd9bbdcd75cec6900