Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: chromeos/network/onc/onc_utils.cc

Issue 433143002: Split onc::IsRecommendedValue into onc_utils.cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/onc/onc_utils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/onc/onc_utils.cc
diff --git a/chromeos/network/onc/onc_utils.cc b/chromeos/network/onc/onc_utils.cc
index 433054fe1feb8b4a8ab7dd2e337241c396352c89..73b5deb9ac6d10354663e73cb6c7859243843b39 100644
--- a/chromeos/network/onc/onc_utils.cc
+++ b/chromeos/network/onc/onc_utils.cc
@@ -672,5 +672,26 @@ NetworkTypePattern NetworkTypePatternFromOncType(const std::string& type) {
return NetworkTypePattern::Default();
}
+bool IsRecommendedValue(const base::DictionaryValue* onc,
+ const std::string& property_key) {
+ std::string property_basename, recommended_property_key;
+ size_t pos = property_key.find_last_of('.');
+ if (pos != std::string::npos) {
+ // 'WiFi.AutoConnect' -> 'AutoConnect', 'WiFi.Recommended'
+ property_basename = property_key.substr(pos + 1);
+ recommended_property_key =
+ property_key.substr(0, pos + 1) + ::onc::kRecommended;
+ } else {
+ // 'Name' -> 'Name', 'Recommended'
+ property_basename = property_key;
+ recommended_property_key = ::onc::kRecommended;
+ }
+
+ const base::ListValue* recommended_keys = NULL;
+ return (onc->GetList(recommended_property_key, &recommended_keys) &&
+ recommended_keys->Find(base::StringValue(property_basename)) !=
+ recommended_keys->end());
+}
+
} // namespace onc
} // namespace chromeos
« no previous file with comments | « chromeos/network/onc/onc_utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698