Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 433133002: Build the importer tests on Windows and Mac OpenSSL. (Closed)

Created:
6 years, 4 months ago by davidben
Modified:
6 years, 4 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Build the importer tests on Windows and Mac OpenSSL. The tests should only be disabled on Android to match the rule in chrome_common.gypi. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287144

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
davidben
6 years, 4 months ago (2014-08-01 20:04:47 UTC) #1
Ryan Sleevi
lgtm
6 years, 4 months ago (2014-08-01 20:09:09 UTC) #2
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 4 months ago (2014-08-01 20:50:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/433133002/1
6 years, 4 months ago (2014-08-01 20:52:50 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 01:36:53 UTC) #5
Message was sent while issue was closed.
Change committed as 287144

Powered by Google App Engine
This is Rietveld 408576698